Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2873373002: 📰 Appropriately mark actions not user triggered
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index ae4e8be02c16ef4a0920f2b417c5d874b5a24cdf..329a06c5712842a96543444bd6f04f615b5a9d52 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -15923,19 +15923,19 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Suggestions.Category.Dismissed">
+<action name="Suggestions.Category.Dismissed" not_user_triggered="true">
Bernhard Bauer 2017/05/11 08:47:01 Given the description this seems a bit strange :)
dgn 2017/05/11 10:37:36 Hum yes agreed. The user-triggered action is "dism
Bernhard Bauer 2017/05/11 13:24:51 I would maybe add an explicit additional sentence
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User dismissed a content suggestions category.</description>
</action>
-<action name="Suggestions.Category.Fetch">
+<action name="Suggestions.Category.Fetch" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User requested fetching more content suggestions.</description>
</action>
-<action name="Suggestions.Category.ViewAll">
+<action name="Suggestions.Category.ViewAll" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>
@@ -15943,13 +15943,13 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Suggestions.Content.Dismissed">
+<action name="Suggestions.Content.Dismissed" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User dismissed a content suggestion.</description>
</action>
-<action name="Suggestions.Content.Opened">
+<action name="Suggestions.Content.Opened" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User opened a content suggestion.</description>
@@ -16005,25 +16005,25 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Suggestions.Site.RemovalUndone">
+<action name="Suggestions.Site.RemovalUndone" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User reverted the removal of a suggested site.</description>
</action>
-<action name="Suggestions.Site.Removed">
+<action name="Suggestions.Site.Removed" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User removed a suggested site.</description>
</action>
-<action name="Suggestions.SurfaceHidden">
+<action name="Suggestions.SurfaceHidden" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User closed the content suggestions UI.</description>
</action>
-<action name="Suggestions.SurfaceVisible">
+<action name="Suggestions.SurfaceVisible" not_user_triggered="true">
<owner>finkm@chromium.org</owner>
<owner>dgn@chromium.org</owner>
<description>User opened the content suggestions UI.</description>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698