Issue 287333002: tcmalloc: Only include cpu profiler in profiling=1 builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287333002: tcmalloc: Only include cpu profiler in profiling=1 builds. (Closed)

Created:
6 years, 7 months ago by Nico

Modified:
6 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

tcmalloc: Only include cpu profiler in profiling=1 builds. tcmalloc's cpu profiler code introduces several static initializers, and it's never used on user machines. So only include it in profiling=1 builds. (The comment for profiling% in build/common.gypi even says that this flag controls if cpuprofiler is used.) BUG=94925 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271321

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : moar #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : different #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	base/allocator/allocator.gyp	View	1 2 3 4 5	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

6 years, 7 months ago (2014-05-19 00:52:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r271321 (presubmit successful).

Expand Messages | Collapse Messages