third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp - Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic (Closed)

Patch Set: Fix GN Issue Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

diff --git a/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp b/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

index 63623c5a74680009a970cd8465f9d82d494d0aa8..80cb8da7b9953f948ee274af30595647e00d4feb 100644

--- a/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

+++ b/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp

@@ -277,9 +277,9 @@ int DOMWrapperWorld::GenerateWorldIdForType(WorldType world_type) {

case WorldType::kInspectorIsolated: {

DCHECK(IsMainThread());

static int next_devtools_isolated_world_id =

- WorldId::kDevToolsFirstIsolatedWorldId;

+ IsolatedWorldId::kDevToolsFirstIsolatedWorldId;

if (next_devtools_isolated_world_id >

- WorldId::kDevToolsLastIsolatedWorldId)

+ IsolatedWorldId::kDevToolsLastIsolatedWorldId)

return WorldId::kInvalidWorldId;

return next_devtools_isolated_world_id++;

}