Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: headless/test/headless_browser_test.cc

Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic (Closed)
Patch Set: Fix GN Issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/test/headless_browser_test.h ('k') | third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/test/headless_browser_test.cc
diff --git a/headless/test/headless_browser_test.cc b/headless/test/headless_browser_test.cc
index 1ad15d8077653c8302b77df83b336575ae76fb8b..f8ff677eb73c4e3066ea2c8ebef45a1217e5d47c 100644
--- a/headless/test/headless_browser_test.cc
+++ b/headless/test/headless_browser_test.cc
@@ -220,7 +220,7 @@ void HeadlessAsyncDevTooledBrowserTest::RunTest() {
HeadlessBrowserContext::Builder builder =
browser()->CreateBrowserContextBuilder();
builder.SetProtocolHandlers(GetProtocolHandlers());
- if (GetCreateTabSocket()) {
+ if (GetTabSocketType() != HeadlessWebContents::Builder::TabSocketType::NONE) {
builder.EnableUnsafeNetworkAccessWithMojoBindings(true);
builder.AddTabSocketMojoBindings();
}
@@ -229,7 +229,7 @@ void HeadlessAsyncDevTooledBrowserTest::RunTest() {
browser()->SetDefaultBrowserContext(browser_context_);
web_contents_ = browser_context_->CreateWebContentsBuilder()
- .CreateTabSocket(GetCreateTabSocket())
+ .SetTabSocketType(GetTabSocketType())
.Build();
web_contents_->AddObserver(this);
@@ -248,7 +248,13 @@ ProtocolHandlerMap HeadlessAsyncDevTooledBrowserTest::GetProtocolHandlers() {
return ProtocolHandlerMap();
}
-bool HeadlessAsyncDevTooledBrowserTest::GetCreateTabSocket() {
+HeadlessWebContents::Builder::TabSocketType
+HeadlessAsyncDevTooledBrowserTest::GetTabSocketType() {
+ return HeadlessWebContents::Builder::TabSocketType::NONE;
+}
+
+bool HeadlessAsyncDevTooledBrowserTest::
+ GetCreateTabSocketOnlyForIsolatedWorld() {
return false;
}
« no previous file with comments | « headless/test/headless_browser_test.h ('k') | third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698