Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic (Closed)
Patch Set: Fix GN Issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/mojo_context_state.cc ('k') | headless/lib/browser/headless_browser_context_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ee634c9620f8ca40f3348cbee79ff94700707c0d..3eec93cbcac9b34ffe074cd111004af31c843c4c 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -6559,14 +6559,17 @@ void RenderFrameImpl::SendUpdateState() {
}
void RenderFrameImpl::MaybeEnableMojoBindings() {
- // BINDINGS_POLICY_WEB_UI, BINDINGS_POLICY_MOJO and BINDINGS_POLICY_HEADLESS
- // are mutually exclusive. They provide access to Mojo bindings, but do so in
- // incompatible ways.
- const int kAllBindingsTypes =
- BINDINGS_POLICY_WEB_UI | BINDINGS_POLICY_MOJO | BINDINGS_POLICY_HEADLESS;
+ // BINDINGS_POLICY_WEB_UI, BINDINGS_POLICY_MOJO,
+ // BINDINGS_POLICY_HEADLESS_MAIN_WORLD and
+ // BINDINGS_POLICY_HEADLESS_ISOLATED_WORLD are mutually exclusive. They
+ // provide access to Mojo bindings, but do so in incompatible ways.
+ const int kAllBindingsTypes = BINDINGS_POLICY_WEB_UI | BINDINGS_POLICY_MOJO |
+ BINDINGS_POLICY_HEADLESS_MAIN_WORLD |
+ BINDINGS_POLICY_HEADLESS_ISOLATED_WORLD;
// Make sure that at most one of BINDINGS_POLICY_WEB_UI, BINDINGS_POLICY_MOJO
- // and BINDINGS_POLICY_HEADLESS have been set.
+ // BINDINGS_POLICY_HEADLESS_MAIN_WORLD and
+ // BINDINGS_POLICY_HEADLESS_ISOLATED_WORLD have been set.
// NOTE x & (x - 1) == 0 is true iff x is zero or a power of two.
DCHECK_EQ((enabled_bindings_ & kAllBindingsTypes) &
((enabled_bindings_ & kAllBindingsTypes) - 1),
@@ -6584,8 +6587,6 @@ void RenderFrameImpl::MaybeEnableMojoBindings() {
new MojoBindingsController(this, MojoBindingsType::FOR_WEB_UI);
} else if (enabled_bindings_ & BINDINGS_POLICY_MOJO) {
new MojoBindingsController(this, MojoBindingsType::FOR_LAYOUT_TESTS);
- } else if (enabled_bindings_ & BINDINGS_POLICY_HEADLESS) {
- new MojoBindingsController(this, MojoBindingsType::FOR_HEADLESS);
}
}
« no previous file with comments | « content/renderer/mojo_context_state.cc ('k') | headless/lib/browser/headless_browser_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698