headless/lib/browser/headless_web_contents_impl.h - Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_web_contents_impl.h

Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic (Closed)

Patch Set: Try and fix build with a dep Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_web_contents_impl.h

diff --git a/headless/lib/browser/headless_web_contents_impl.h b/headless/lib/browser/headless_web_contents_impl.h

index 93edc99d60de7d77285d06627ac7450f56c3ff65..ef535f8651e69b59d10b2064ceace9d812edd793 100644

--- a/headless/lib/browser/headless_web_contents_impl.h

+++ b/headless/lib/browser/headless_web_contents_impl.h

@@ -115,6 +115,7 @@ class HEADLESS_EXPORT HeadlessWebContentsImpl

std::unique_ptr<content::WebContents> web_contents_;

scoped_refptr<content::DevToolsAgentHost> agent_host_;

std::list<MojoService> mojo_services_;

+ bool inject_mojo_services_into_isolated_world_;

Sami 2017/05/16 13:49:14 Not initialized in constructor?

alex clarke (OOO till 29th) 2017/05/17 09:09:32 Done.

std::unique_ptr<HeadlessTabSocketImpl> headless_tab_socket_;

HeadlessBrowserContextImpl* browser_context_; // Not owned.