headless/lib/renderer/devtools_isolated_world_ids.h - Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: headless/lib/renderer/devtools_isolated_world_ids.h

Issue 2873283002: [Reland] Allow headless TabSocket in isolated worlds & remove obsolete logic (Closed)

Patch Set: Changes for Sami Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef HEADLESS_LIB_RENDERER_DEVTOOLS_ISOLATED_WORLD_IDS_H_

	6 #define HEADLESS_LIB_RENDERER_DEVTOOLS_ISOLATED_WORLD_IDS_H_

	7

	8 namespace headless {

	9

	10 // Keep in sync with DOMWrapperWorld::WorldId.

	11 enum {

	12 kDevToolsFirstIsolatedWorldId = (1 << 29) + 1,

	13 kDevToolsLastIsolatedWorldId = kDevToolsFirstIsolatedWorldId + 100,

	14 };
	jochen (gone - plz use gerrit) 2017/05/19 13:34:05 why not put this file in public/web ? it's ok for why not put this file in public/web ? it's ok for webkit to include headers from public/web alex clarke (OOO till 29th) 2017/05/19 14:53:01 Done. I wonder if I should have pulled all the en Show quoted text On 2017/05/19 13:34:05, jochen wrote: > why not put this file in public/web ? it's ok for webkit to include headers from > public/web Done. I wonder if I should have pulled all the enums from DOMWrapperWorld in too? I didn't because the comments mentioning DOMWrapperWorld APIs felt odd to be there.
	15

	16 } // namespace headless

	17

	18 #endif // HEADLESS_LIB_RENDERER_DEVTOOLS_ISOLATED_WORLD_IDS_H_

OLD	NEW