Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2873213003: Move WebFrame to use WebLocalFrameBase instead of WebLocalFrameImpl. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 enum class WebFrameLoadType; 77 enum class WebFrameLoadType;
78 struct FrameLoadRequest; 78 struct FrameLoadRequest;
79 struct WebContentSecurityPolicyViolation; 79 struct WebContentSecurityPolicyViolation;
80 struct WebPrintParams; 80 struct WebPrintParams;
81 81
82 template <typename T> 82 template <typename T>
83 class WebVector; 83 class WebVector;
84 84
85 // Implementation of WebFrame, note that this is a reference counted object. 85 // Implementation of WebFrame, note that this is a reference counted object.
86 class WEB_EXPORT WebLocalFrameImpl final 86 class WEB_EXPORT WebLocalFrameImpl final
87 : public GarbageCollectedFinalized<WebLocalFrameImpl>, 87 : NON_EXPORTED_BASE(public WebLocalFrameBase) {
88 NON_EXPORTED_BASE(public WebLocalFrameBase) {
89 public: 88 public:
90 // WebFrame methods: 89 // WebFrame methods:
91 // TODO(dcheng): Fix sorting here; a number of method have been moved to 90 // TODO(dcheng): Fix sorting here; a number of method have been moved to
92 // WebLocalFrame but not correctly updated here. 91 // WebLocalFrame but not correctly updated here.
93 void Close() override; 92 void Close() override;
94 WebString AssignedName() const override; 93 WebString AssignedName() const override;
95 void SetName(const WebString&) override; 94 void SetName(const WebString&) override;
96 WebVector<WebIconURL> IconURLs(int icon_types_mask) const override; 95 WebVector<WebIconURL> IconURLs(int icon_types_mask) const override;
97 void SetSharedWorkerRepositoryClient( 96 void SetSharedWorkerRepositoryClient(
98 WebSharedWorkerRepositoryClient*) override; 97 WebSharedWorkerRepositoryClient*) override;
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 void UsageCountChromeLoadTimes(const WebString& metric) override; 311 void UsageCountChromeLoadTimes(const WebString& metric) override;
313 base::SingleThreadTaskRunner* TimerTaskRunner() override; 312 base::SingleThreadTaskRunner* TimerTaskRunner() override;
314 base::SingleThreadTaskRunner* LoadingTaskRunner() override; 313 base::SingleThreadTaskRunner* LoadingTaskRunner() override;
315 base::SingleThreadTaskRunner* UnthrottledTaskRunner() override; 314 base::SingleThreadTaskRunner* UnthrottledTaskRunner() override;
316 WebInputMethodControllerImpl* GetInputMethodController() const override; 315 WebInputMethodControllerImpl* GetInputMethodController() const override;
317 316
318 void ExtractSmartClipData(WebRect rect_in_viewport, 317 void ExtractSmartClipData(WebRect rect_in_viewport,
319 WebString& clip_text, 318 WebString& clip_text,
320 WebString& clip_html) override; 319 WebString& clip_html) override;
321 320
322 void InitializeCoreFrame(Page&, FrameOwner*, const AtomicString& name); 321 void InitializeCoreFrame(Page&,
322 FrameOwner*,
323 const AtomicString& name) override;
323 LocalFrame* GetFrame() const override { return frame_.Get(); } 324 LocalFrame* GetFrame() const override { return frame_.Get(); }
324 325
325 void WillBeDetached(); 326 void WillBeDetached();
326 void WillDetachParent(); 327 void WillDetachParent();
327 328
328 static WebLocalFrameImpl* Create(WebTreeScopeType, 329 static WebLocalFrameImpl* Create(WebTreeScopeType,
329 WebFrameClient*, 330 WebFrameClient*,
330 blink::InterfaceProvider*, 331 blink::InterfaceProvider*,
331 blink::InterfaceRegistry*, 332 blink::InterfaceRegistry*,
332 WebFrame* opener); 333 WebFrame* opener);
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 WebDevToolsFrontendImpl* DevToolsFrontend() { 429 WebDevToolsFrontendImpl* DevToolsFrontend() {
429 return web_dev_tools_frontend_; 430 return web_dev_tools_frontend_;
430 } 431 }
431 432
432 WebNode ContextMenuNode() const { return context_menu_node_.Get(); } 433 WebNode ContextMenuNode() const { return context_menu_node_.Get(); }
433 void SetContextMenuNode(Node* node) override { context_menu_node_ = node; } 434 void SetContextMenuNode(Node* node) override { context_menu_node_ = node; }
434 void ClearContextMenuNode() override { context_menu_node_.Clear(); } 435 void ClearContextMenuNode() override { context_menu_node_.Clear(); }
435 436
436 std::unique_ptr<WebURLLoader> CreateURLLoader() override; 437 std::unique_ptr<WebURLLoader> CreateURLLoader() override;
437 438
438 DECLARE_TRACE(); 439 DECLARE_VIRTUAL_TRACE();
439 440
440 private: 441 private:
441 friend class LocalFrameClientImpl; 442 friend class LocalFrameClientImpl;
442 443
443 WebLocalFrameImpl(WebTreeScopeType, 444 WebLocalFrameImpl(WebTreeScopeType,
444 WebFrameClient*, 445 WebFrameClient*,
445 blink::InterfaceProvider*, 446 blink::InterfaceProvider*,
446 blink::InterfaceRegistry*); 447 blink::InterfaceRegistry*);
447 WebLocalFrameImpl(WebRemoteFrame*, 448 WebLocalFrameImpl(WebRemoteFrame*,
448 WebFrameClient*, 449 WebFrameClient*,
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 524
524 DEFINE_TYPE_CASTS(WebLocalFrameImpl, 525 DEFINE_TYPE_CASTS(WebLocalFrameImpl,
525 WebFrame, 526 WebFrame,
526 frame, 527 frame,
527 frame->IsWebLocalFrame(), 528 frame->IsWebLocalFrame(),
528 frame.IsWebLocalFrame()); 529 frame.IsWebLocalFrame());
529 530
530 } // namespace blink 531 } // namespace blink
531 532
532 #endif 533 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698