Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 2873193002: Make update over cellular an option for user (Closed)
Patch Set: Put code in CHROME_OS wrapper to fix trybot error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.h ('k') | chrome/browser/ui/webui/help/version_updater.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index cb2cc35559df519c30e3c94104eb33052a8ce467..d0a18970628713416f79d8221903fc78c40b4e44 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -602,7 +602,10 @@ void HelpHandler::RequestUpdate(const base::ListValue* args) {
}
void HelpHandler::SetUpdateStatus(VersionUpdater::Status status,
- int progress, const base::string16& message) {
+ int progress,
+ const std::string& /* version */,
+ int64_t /* size */,
+ const base::string16& message) {
// Only UPDATING state should have progress set.
DCHECK(status == VersionUpdater::UPDATING || progress == 0);
@@ -623,6 +626,9 @@ void HelpHandler::SetUpdateStatus(VersionUpdater::Status status,
case VersionUpdater::FAILED:
case VersionUpdater::FAILED_OFFLINE:
case VersionUpdater::FAILED_CONNECTION_TYPE_DISALLOWED:
+ // Old help page does not support update over cellular connection. Treat this
+ // signal as FAILED.
+ case VersionUpdater::NEED_PERMISSION_TO_UPDATE:
status_str = "failed";
break;
case VersionUpdater::DISABLED:
« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.h ('k') | chrome/browser/ui/webui/help/version_updater.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698