Make update over cellular an option for user

chrome/browser/resources/settings/about_page/about_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-

[xiyuan, 2017/05/11 20:37:25]

nit: restore this empty line and insert one after the @fileoverview comment.

 /**
  * @fileoverview 'settings-about-page' contains version and OS related
  * information.
  */
 Polymer({
   is: 'settings-about-page',
 
   behaviors: [WebUIListenerBehavior, MainPageBehavior, I18nBehavior],
 
   properties: {
@@ skipping 62 matching lines @@
     /** @private {!Map<string, string>} */
     focusConfig_: {
       type: Object,
       value: function() {
         var map = new Map();
         map.set(
             settings.Route.DETAILED_BUILD_INFO.path,
             '#detailed-build-info-trigger');
         return map;
       },
-    }
+    },
+
+    /** @private */
+    showUpdateWarningDialog_: {
+      type: Boolean,
+      value: false,
+    },
+
+    /** @private {!AboutPageUpdateInfo|undefined} */
+    updateInfo_: Object,
 // </if>
   },
 
   observers: [
 // <if expr="not chromeos">
     'updateShowUpdateStatus_(' +
         'obsoleteSystemInfo_, currentUpdateStatusEvent_)',
     'updateShowRelaunch_(currentUpdateStatusEvent_)',
     'updateShowButtonContainer_(showRelaunch_)',
 // </if>
@@ skipping 58 matching lines @@
   },
 
   /**
    * @param {!UpdateStatusChangedEvent} event
    * @private
    */
   onUpdateStatusChanged_: function(event) {
 // <if expr="chromeos">
     if (event.status == UpdateStatus.CHECKING)
       this.hasCheckedForUpdates_ = true;
+    else if (event.status == UpdateStatus.NEED_PERMISSION_TO_UPDATE) {
+      this.showUpdateWarningDialog_ = true;
+      this.updateInfo_ = {version: event.version, size: event.size};
+    }
 // </if>
     this.currentUpdateStatusEvent_ = event;
   },
 
 // <if expr="_google_chrome and is_macosx">
   /**
    * @param {!PromoteUpdaterStatus} status
    * @private
    */
   onPromoteUpdaterStatusChanged_: function(status) {
@@ skipping 75 matching lines @@
   },
 
   /**
    * @return {string}
    * @private
    */
   getUpdateStatusMessage_: function() {
     switch (this.currentUpdateStatusEvent_.status) {
       case UpdateStatus.CHECKING:
         return this.i18n('aboutUpgradeCheckStarted');
+      case UpdateStatus.NEED_PERMISSION_TO_UPDATE:
+        return "";

[xiyuan, 2017/05/11 20:37:25]

If this is intended, please document why. Otherwise create a proper message or
at least put a TODO.

[stevenjb, 2017/05/11 21:03:45]

Also use '' not "" (but it seems like we should have a proper message here?)

[weidongg, 2017/05/11 23:50:44]

This transition is
IDLE->CHECKING_FOR_UPDATE->NEED_PERMISSION_TO_UPDATE->REPORTING_ERROR_EVENT
->IDLE. Right now the UI shows your device is update to date upon error event.
This behavior should be changed in the future.

       case UpdateStatus.NEARLY_UPDATED:
 // <if expr="chromeos">
         if (this.currentChannel_ != this.targetChannel_)
           return this.i18n('aboutUpgradeSuccessChannelSwitch');
 // </if>
         return this.i18n('aboutUpgradeRelaunch');
       case UpdateStatus.UPDATED:
         return this.i18n('aboutUpgradeUpToDate');
       case UpdateStatus.UPDATING:
         assert(typeof this.currentUpdateStatusEvent_.progress == 'number');
@@ skipping 121 matching lines @@
   /**
    * @return {boolean}
    * @private
    */
   computeShowCheckUpdates_: function() {
     // Enable the update button if we are in a stale 'updated' status or
     // update has failed. Disable it otherwise.
     var staleUpdatedStatus = !this.hasCheckedForUpdates_ &&
         this.checkStatus_(UpdateStatus.UPDATED);
 
-    return staleUpdatedStatus || this.checkStatus_(UpdateStatus.FAILED);
+    return staleUpdatedStatus || this.checkStatus_(UpdateStatus.FAILED) ||
+        this.checkStatus_(UpdateStatus.NEED_PERMISSION_TO_UPDATE);
   },
 
   /**
    * @return {boolean}
    * @private
    */
   shouldShowRegulatoryInfo_: function() {
     return this.regulatoryInfo_ !== null;
   },
+
+  /** @private */
+  onUpdateWarningDialogClose_: function() {
+    this.showUpdateWarningDialog_ = false;
+  },
 // </if>
 
   /** @private */
   onProductLogoTap_: function() {
     this.$['product-logo'].animate({
       transform: ['none', 'rotate(-10turn)'],
     }, {
       duration: 500,
       easing: 'cubic-bezier(1, 0, 0, 1)',
     });
   },
 
 // <if expr="_google_chrome">
   /** @private */
   onReportIssueTap_: function() {
     this.aboutBrowserProxy_.openFeedbackDialog();
   },
 // </if>
 });