Make update over cellular an option for user

chrome/browser/resources/settings/about_page/update_warning_dialog.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-update-warning-dialog' is a component warning the
  * user about update over mobile data. By clicking 'Continue', the user
  * agrees to download update using mobile data.
  */
 Polymer({
   is: 'settings-update-warning-dialog',
 
   behaviors: [I18nBehavior],
 
+  properties: {
+    /** @public */

[stevenjb, 2017/05/11 17:20:16]

We don't use @public since that is the default. We do need a type though:

/** @type {!AboutPageUpdateInfo|undefined} */

[weidongg, 2017/05/11 18:09:30]

Done.

+    updateInfo: {
+      type: Object,
+      value: {version: '', size: ''},

[stevenjb, 2017/05/11 17:20:16]

Shouldn't need to provide a default value here since it will always be set by
the page.

[weidongg, 2017/05/11 18:09:30]

Done.

+      observer: '_updateInfoChanged',

[stevenjb, 2017/05/11 17:20:16]

Polymer uses _foo, but in the WebUI code we use foo_.

[weidongg, 2017/05/11 18:09:30]

Done.

+    },
+  },
+
+  /** @private {?settings.AboutPageBrowserProxy} */
+  browserProxy_: null,
+
   /** @override */
   ready: function() {
     this.browserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
   },
 
   /** @override */
   attached: function() {
     this.$.dialog.showModal();
   },
 
   /** @private */
   onCancelTap_: function() {
-    // TODO(weidongg): implement the real behaviors here.
     this.$.dialog.close();
   },
 
   /** @private */
   onContinueTap_: function() {
-    // TODO(weidongg): implement the real behaviors here.
+    this.browserProxy_.requestUpdateOverCellular(this.updateInfo.version,
+                                                 this.updateInfo.size);
     this.$.dialog.close();
   },
 
   /**
-   * @param {string} updateSizeMb Size of the update in megabytes.
+   * @param {string} updateSize Size of the update in bytes.
    * @private
    */
-  setUpdateWarningMessage: function(updateSizeMb) {
-     this.$$("#update-warning-message").innerHTML =
-         this.i18n("aboutUpdateWarningMessage", updateSizeMb);
+  _updateInfoChanged: function() {

[stevenjb, 2017/05/11 17:20:16]

updateInfoChanged_:

[weidongg, 2017/05/11 18:09:30]

Done.

+    this.$$("#update-warning-message").innerHTML =
+        this.i18n("aboutUpdateWarningMessage",
+                  // Convert bytes to megabytes
+                  Math.floor(Number(this.updateInfo.size) / (1024 * 1024)));
   },
 });