Remove the length check of benchmark's positional_args

Remove the length check of benchmark's positional_args

This allows benchmark to define their own logic for handling positional_args.
In particular, this is used for enabling user of blink_perf benchmark to
run a test directory of interest through positional argument (see https://codereview.chromium.org/2874653002/)

[nednguyen, 2017-05-10 01:31:43]

nednguyen@google.com changed reviewers:
+ charliea@chromium.org

[nednguyen, 2017-05-10 01:31:54]

Description was changed from

==========
Remove the length check of benchmark's positional_args

This allows benchmark to define their own logic for handling positional_args.
In particular, this is used for enabling user of blink_perf benchmark to
run a test directory of interest through positional argument (see ..)
==========

to

==========
Remove the length check of benchmark's positional_args

This allows benchmark to define their own logic for handling positional_args.
In particular, this is used for enabling user of blink_perf benchmark to
run a test directory of interest through positional argument (see ..)
==========

[nednguyen, 2017-05-10 01:31:54]

nednguyen@google.com changed reviewers:
+ perezju@chromium.org

[nednguyen, 2017-05-10 01:31:59]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:32:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-05-10 01:34:21]

Description was changed from

==========
Remove the length check of benchmark's positional_args

This allows benchmark to define their own logic for handling positional_args.
In particular, this is used for enabling user of blink_perf benchmark to
run a test directory of interest through positional argument (see ..)
==========

to

==========
Remove the length check of benchmark's positional_args

This allows benchmark to define their own logic for handling positional_args.
In particular, this is used for enabling user of blink_perf benchmark to
run a test directory of interest through positional argument (see
https://codereview.chromium.org/2874653002/)
==========

[commit-bot: I haz the power, 2017-05-10 01:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:56:41]

Dry run: This issue passed the CQ dry run.

[charliea (OOO until 10-5), 2017-05-10 17:38:23]

Is there any reason blink_perf can't just use a command line arg
(--blink-perf-test-dir=...)? The reason I ask is that I always think of
positional args as things that mean the same thing for a given command (where
command is something like run_benchmark). Allowing benchmarks to override this
is likely to get confusing.

[charliea (OOO until 10-5), 2017-05-10 17:43:17]

On 2017/05/10 17:38:23, charliea wrote:
> Is there any reason blink_perf can't just use a command line arg
> (--blink-perf-test-dir=...)? The reason I ask is that I always think of
> positional args as things that mean the same thing for a given command (where
> command is something like run_benchmark). Allowing benchmarks to override this
> is likely to get confusing.

Bah, never mind. ./tools/battor_agent/battor_agent RecordClockSyncMarker xyz.123
was a counterexample to this (before battor_agent was an interactive shell).

Can you add a unit test for this?

[nednguyen, 2017-05-10 17:43:29]

On 2017/05/10 17:38:23, charliea wrote:
> Is there any reason blink_perf can't just use a command line arg
> (--blink-perf-test-dir=...)? 
Less typing for the user. The current semantic of
"./third_party/WebKit/Tools/Scripts/run-perf-tests" is you just need to point
the script at a directory to run it.

> The reason I ask is that I always think of
> positional args as things that mean the same thing for a given command (where
> command is something like run_benchmark). 

I don't get this sentence. Can you rephrase?
> Allowing benchmarks to override this
> is likely to get confusing.

[nednguyen, 2017-05-10 21:04:48]

On 2017/05/10 17:43:29, nednguyen wrote:
> On 2017/05/10 17:38:23, charliea wrote:
> > Is there any reason blink_perf can't just use a command line arg
> > (--blink-perf-test-dir=...)? 
> Less typing for the user. The current semantic of
> "./third_party/WebKit/Tools/Scripts/run-perf-tests" is you just need to point
> the script at a directory to run it.
> 
> > The reason I ask is that I always think of
> > positional args as things that mean the same thing for a given command
(where
> > command is something like run_benchmark). 
> 
> I don't get this sentence. Can you rephrase?
> > Allowing benchmarks to override this
> > is likely to get confusing.

Dropping this since we went with "--test-path" option in the other CL.