Issue 287313004: FileDefinitionListConverter::OnResolvedURL should not fall-through.

Issue 287313004: FileDefinitionListConverter::OnResolvedURL should not fall-through. (Closed)

Created:
6 years, 7 months ago by kinaba

Modified:
6 years, 7 months ago

Reviewers:
hirono

CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

FileDefinitionListConverter::OnResolvedURL should not fall-through. BUG=374722 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271378

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/file_manager/fileapi_util.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinaba

PTAL. Note that the affected code path is something that should not be hit by ...

6 years, 7 months ago (2014-05-19 09:07:37 UTC) #1

hirono

On 2014/05/19 09:07:37, kinaba wrote: > PTAL. > > Note that the affected code path ...

6 years, 7 months ago (2014-05-19 09:21:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/287313004/1

6 years, 7 months ago (2014-05-19 09:25:20 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-19 12:46:55 UTC) #5

Message was sent while issue was closed.

Change committed as 271378

Expand Messages | Collapse Messages