content/renderer/media/webrtc/media_stream_remote_video_source.cc - Issue 287313002: Pass a TimeTicks along video capture pipeline to represent capture time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 287313002: Pass a TimeTicks along video capture pipeline to represent capture time (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/media/cast_rtp_stream.cc ('K') | « content/renderer/media/video_track_adapter.cc ('k') | content/renderer/media/webrtc/video_destination_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

index d2984f50ca9675c3393cca2723e81e6c179bf599..28e07259932774d5ef8b55035dd61bc585554e30 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

@@ -120,7 +120,9 @@ RemoteVideoSourceDelegate::DoRenderFrameOnIOThread(

scoped_refptr<media::VideoFrame> video_frame,

const media::VideoCaptureFormat& format) {

DCHECK(io_message_loop_->BelongsToCurrentThread());

- frame_callback_.Run(video_frame, format);

+ // We cannot estimate the local time when this frame is generated so give a

+ // null value to |estimated_capture_time|.

Ronghua Wu (Left Chromium) 2014/06/02 18:09:09 The comment is not accurate. We do have estimated

+ frame_callback_.Run(video_frame, format, base::TimeTicks());

}

MediaStreamRemoteVideoSource::MediaStreamRemoteVideoSource(