Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2873113004: Add equivalence check of NativeData and InterceptorData (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index f8848b22bce9a26af2d1ecac619afc5e73992c90..3704f440c10e9441ef351a281700b6341b2d03a1 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -123,8 +123,9 @@ class KernelImpactBuilder extends ir.Visitor {
}
if (field.isInstanceMember &&
elementAdapter.isNativeClass(field.enclosingClass)) {
- impactBuilder.registerNativeData(
- elementAdapter.getNativeBehaviorForFieldLoad(field));
+ // TODO(johnniwinther): Provide the correct value for [isJsInterop].
+ impactBuilder.registerNativeData(elementAdapter
+ .getNativeBehaviorForFieldLoad(field, isJsInterop: false));
impactBuilder.registerNativeData(
elementAdapter.getNativeBehaviorForFieldStore(field));
}
@@ -163,8 +164,9 @@ class KernelImpactBuilder extends ir.Visitor {
handleAsyncMarker(procedure.function.asyncMarker);
if (procedure.isExternal &&
!elementAdapter.isForeignLibrary(procedure.enclosingLibrary)) {
- impactBuilder.registerNativeData(
- elementAdapter.getNativeBehaviorForMethod(procedure));
+ // TODO(johnniwinther): Provide the correct value for [isJsInterop].
+ impactBuilder.registerNativeData(elementAdapter
+ .getNativeBehaviorForMethod(procedure, isJsInterop: false));
}
return impactBuilder;
}

Powered by Google App Engine
This is Rietveld 408576698