Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: pkg/compiler/lib/src/kernel/element_map.dart

Issue 2873113004: Add equivalence check of NativeData and InterceptorData (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/element_map.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map.dart b/pkg/compiler/lib/src/kernel/element_map.dart
index 321d88f2147e52bcfde427e4d5d531d83d216e22..616b52ec9ad871f6f3a909e638fc0ce47610421a 100644
--- a/pkg/compiler/lib/src/kernel/element_map.dart
+++ b/pkg/compiler/lib/src/kernel/element_map.dart
@@ -83,13 +83,15 @@ abstract class KernelToElementMap {
bool isForeignLibrary(ir.Library node);
/// Computes the native behavior for reading the native [field].
- native.NativeBehavior getNativeBehaviorForFieldLoad(ir.Field field);
+ native.NativeBehavior getNativeBehaviorForFieldLoad(ir.Field field,
+ {bool isJsInterop});
/// Computes the native behavior for writing to the native [field].
native.NativeBehavior getNativeBehaviorForFieldStore(ir.Field field);
/// Computes the native behavior for calling [procedure].
- native.NativeBehavior getNativeBehaviorForMethod(ir.Procedure procedure);
+ native.NativeBehavior getNativeBehaviorForMethod(ir.Procedure procedure,
+ {bool isJsInterop});
/// Computes the [native.NativeBehavior] for a call to the [JS] function.
native.NativeBehavior getNativeBehaviorForJsCall(ir.StaticInvocation node);
@@ -417,13 +419,13 @@ abstract class KernelToElementMapMixin implements KernelToElementMap {
/// Computes the native behavior for reading the native [field].
// TODO(johnniwinther): Cache this for later use.
- native.NativeBehavior getNativeBehaviorForFieldLoad(ir.Field field) {
+ native.NativeBehavior getNativeBehaviorForFieldLoad(ir.Field field,
+ {bool isJsInterop}) {
DartType type = getDartType(field.type);
List<ConstantValue> metadata = getMetadata(field.annotations);
- // TODO(johnniwinther): Provide the correct value for [isJsInterop].
return nativeBehaviorBuilder.buildFieldLoadBehavior(
type, metadata, typeLookup(resolveAsRaw: false),
- isJsInterop: false);
+ isJsInterop: isJsInterop);
}
/// Computes the native behavior for writing to the native [field].
@@ -435,13 +437,13 @@ abstract class KernelToElementMapMixin implements KernelToElementMap {
/// Computes the native behavior for calling [procedure].
// TODO(johnniwinther): Cache this for later use.
- native.NativeBehavior getNativeBehaviorForMethod(ir.Procedure procedure) {
+ native.NativeBehavior getNativeBehaviorForMethod(ir.Procedure procedure,
+ {bool isJsInterop}) {
DartType type = getFunctionType(procedure.function);
List<ConstantValue> metadata = getMetadata(procedure.annotations);
- // TODO(johnniwinther): Provide the correct value for [isJsInterop].
return nativeBehaviorBuilder.buildMethodBehavior(
type, metadata, typeLookup(resolveAsRaw: false),
- isJsInterop: false);
+ isJsInterop: isJsInterop);
}
}

Powered by Google App Engine
This is Rietveld 408576698