chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java - Issue 2873103003: Implements logging in the new compact translate UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

Issue 2873103003: Implements logging in the new compact translate UI. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateOptions.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

index 3c0f042b63415e34f04c02cf18d282c65b7fcbd9..b41586f23b4b7771fd7859fcd067d0e440a0b118 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateLanguagePanel.java

@@ -175,7 +175,7 @@ public class TranslateLanguagePanel

private ArrayList<SpinnerLanguageElement> createSpinnerLanguages(String avoidCode) {

ArrayList<SpinnerLanguageElement> result = new ArrayList<SpinnerLanguageElement>();

- for (TranslateOptions.TranslateLanguagePair language : mSessionOptions.allLanguages()) {

+ for (TranslateOptions.TranslateLanguageData language : mSessionOptions.allLanguages()) {

if (!language.mLanguageCode.equals(avoidCode)) {

result.add(new SpinnerLanguageElement(

language.mLanguageRepresentation, language.mLanguageCode));