Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: chrome/browser/ui/android/infobars/translate_compact_infobar.cc

Issue 2873103003: Implements logging in the new compact translate UI. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/translate/android/translate_utils.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h" 5 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 25 matching lines...) Expand all
36 } 36 }
37 37
38 ScopedJavaLocalRef<jobject> TranslateCompactInfoBar::CreateRenderInfoBar( 38 ScopedJavaLocalRef<jobject> TranslateCompactInfoBar::CreateRenderInfoBar(
39 JNIEnv* env) { 39 JNIEnv* env) {
40 translate::TranslateInfoBarDelegate* delegate = GetDelegate(); 40 translate::TranslateInfoBarDelegate* delegate = GetDelegate();
41 41
42 base::android::ScopedJavaLocalRef<jobjectArray> java_languages = 42 base::android::ScopedJavaLocalRef<jobjectArray> java_languages =
43 TranslateUtils::GetJavaLanguages(env, delegate); 43 TranslateUtils::GetJavaLanguages(env, delegate);
44 base::android::ScopedJavaLocalRef<jobjectArray> java_codes = 44 base::android::ScopedJavaLocalRef<jobjectArray> java_codes =
45 TranslateUtils::GetJavaLanguageCodes(env, delegate); 45 TranslateUtils::GetJavaLanguageCodes(env, delegate);
46 base::android::ScopedJavaLocalRef<jintArray> java_hash_codes =
47 TranslateUtils::GetJavaLanguageHashCodes(env, delegate);
46 48
47 ScopedJavaLocalRef<jstring> source_language_code = 49 ScopedJavaLocalRef<jstring> source_language_code =
48 base::android::ConvertUTF8ToJavaString( 50 base::android::ConvertUTF8ToJavaString(
49 env, delegate->original_language_code()); 51 env, delegate->original_language_code());
50 52
51 ScopedJavaLocalRef<jstring> target_language_code = 53 ScopedJavaLocalRef<jstring> target_language_code =
52 base::android::ConvertUTF8ToJavaString(env, 54 base::android::ConvertUTF8ToJavaString(env,
53 delegate->target_language_code()); 55 delegate->target_language_code());
54 return Java_TranslateCompactInfoBar_create( 56 return Java_TranslateCompactInfoBar_create(
55 env, delegate->translate_step(), source_language_code, 57 env, delegate->translate_step(), source_language_code,
56 target_language_code, delegate->ShouldAlwaysTranslate(), 58 target_language_code, delegate->ShouldAlwaysTranslate(),
57 delegate->triggered_from_menu(), java_languages, java_codes); 59 delegate->triggered_from_menu(), java_languages, java_codes,
60 java_hash_codes);
58 } 61 }
59 62
60 void TranslateCompactInfoBar::ProcessButton(int action) { 63 void TranslateCompactInfoBar::ProcessButton(int action) {
61 if (!owner()) 64 if (!owner())
62 return; // We're closing; don't call anything, it might access the owner. 65 return; // We're closing; don't call anything, it might access the owner.
63 66
64 // TODO(ramyasharma): Handle other button clicks. 67 // TODO(ramyasharma): Handle other button clicks.
65 translate::TranslateInfoBarDelegate* delegate = GetDelegate(); 68 translate::TranslateInfoBarDelegate* delegate = GetDelegate();
66 if (action == InfoBarAndroid::ACTION_TRANSLATE) { 69 if (action == InfoBarAndroid::ACTION_TRANSLATE) {
67 delegate->Translate(); 70 delegate->Translate();
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 translate::TranslateInfoBarDelegate* TranslateCompactInfoBar::GetDelegate() { 156 translate::TranslateInfoBarDelegate* TranslateCompactInfoBar::GetDelegate() {
154 return delegate()->AsTranslateInfoBarDelegate(); 157 return delegate()->AsTranslateInfoBarDelegate();
155 } 158 }
156 159
157 // Native JNI methods --------------------------------------------------------- 160 // Native JNI methods ---------------------------------------------------------
158 161
159 // static 162 // static
160 bool RegisterTranslateCompactInfoBar(JNIEnv* env) { 163 bool RegisterTranslateCompactInfoBar(JNIEnv* env) {
161 return RegisterNativesImpl(env); 164 return RegisterNativesImpl(env);
162 } 165 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/android/translate_utils.cc ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698