Implements logging in the new compact translate UI.

chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.support.design.widget.TabLayout;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.widget.LinearLayout;
 
 import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.infobar.translate.TranslateMenu;
 import org.chromium.chrome.browser.infobar.translate.TranslateMenuHelper;
 import org.chromium.chrome.browser.infobar.translate.TranslateTabLayout;
 import org.chromium.chrome.browser.snackbar.Snackbar;
 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
 import org.chromium.chrome.browser.widget.TintedImageButton;
 import org.chromium.ui.widget.Toast;
 
 /**
  * Java version of the compcat translate infobar
  */
 class TranslateCompactInfoBar extends InfoBar
         implements TabLayout.OnTabSelectedListener, TranslateMenuHelper.TranslateMenuListener {
     public static final int TRANSLATING_INFOBAR = 1;
 
     private static final int SOURCE_TAB_INDEX = 0;
     private static final int TARGET_TAB_INDEX = 1;
 
     private final int mInitialStep;
     private final TranslateOptions mOptions;
 
     private long mNativeTranslateInfoBarPtr;
     private TranslateTabLayout mTabLayout;
 
+    private static final String INFOBAR_HISTOGRAM_TRANSLATE_LANGUAGE =

[Leo, 2017/05/10 07:23:58]

Any chance moving all the definitions to Metrics.java under translate and
provide a convenient util to do logging shortly?

[ramyasharma, 2017/05/10 09:54:52]

Hmmm.. as we discussed, keeping these metrics in this file, as they are not used
outside this class. If required we can move it in the future. 

+            "Translate.Compact.infobar_translate_language";
+    private static final String INFOBAR_HISTOGRAM_MORE_LANGUAGES_LANGUAGE =
+            "Translate.Compact.infobar_more_languages_translate_language";
+    private static final String INFOBAR_HISTOGRAM_PAGE_NOT_IN_LANGUAGE =
+            "Translate.Compact.infobar_page_not_in_language";
+    private static final String INFOBAR_HISTOGRAM_ALWAYS_TRANSLATE_LANGUAGE =
+            "Translate.Compact.infobar_always_translate_lang";
+    private static final String INFOBAR_HISTOGRAM_NEVER_TRANSLATE_LANGUAGE =
+            "Translate.Compact.infobar_never_translate_lang";

[Ilya Sherman, 2017/05/10 07:10:20]

Did you mean to add these histograms to histograms.xml?  Also, why are the
suffixes hacker_case rather than CamelCase?

[ramyasharma, 2017/05/10 09:54:52]

Yes, sorry I missed this. 
Fixed the case thanks.

+    private static final String INFOBAR_HISTOGRAM = "Translate.Compact";
+
+    /**
+     * This is used to back a UMA histogram, so it should be treated as
+     * append-only. The values should not be changed or reused, and
+     * INFOBAR_HISTOGRAM_BOUNDARY should be the last.
+     */
+    private static final Integer INFOBAR_IMPRESSION = 0;
+    private static final Integer INFOBAR_TRANSLATE = 1;
+    private static final Integer INFOBAR_DECLINE = 2;
+    private static final Integer INFOBAR_OPTIONS = 3;
+    private static final Integer INFOBAR_MORE_LANGUAGES = 4;
+    private static final Integer INFOBAR_MORE_LANGUAGES_TRANSLATE = 5;
+    private static final Integer INFOBAR_PAGE_NOT_IN = 6;
+    private static final Integer INFOBAR_ALWAYS_TRANSLATE = 7;
+    private static final Integer INFOBAR_NEVER_TRANSLATE = 8;
+    private static final Integer INFOBAR_NEVER_TRANSLATE_SITE = 9;
+    private static final Integer INFOBAR_SCROLL_HIDE = 10;
+    private static final Integer INFOBAR_SCROLL_SHOW = 11;
+    private static final Integer INFOBAR_REVERT = 12;
+    private static final Integer INFOBAR_SNACKBAR_CANCEL_ALWAYS = 13;
+    private static final Integer INFOBAR_SNACKBAR_CANCEL_NEVER_SITE = 14;
+    private static final Integer INFOBAR_SNACKBAR_CANCEL_NEVER = 15;
+    private static final Integer INFOBAR_HISTOGRAM_BOUNDARY = 16;
+
     // Need 2 instances of TranslateMenuHelper to prevent a race condition bug which happens when
     // showing language menu after dismissing overflow menu.
     private TranslateMenuHelper mOverflowMenuHelper;
     private TranslateMenuHelper mLanguageMenuHelper;
 
     private TintedImageButton mMenuButton;
 
     /** The controller for translate UI snackbars. */
     class TranslateSnackbarController implements SnackbarController {
         private final int mMenuItemId;
 
         public TranslateSnackbarController(int menuItemId) {
             mMenuItemId = menuItemId;
         }
 
         @Override
         public void onDismissNoAction(Object actionData) {
             handleTranslateOptionPostSnackbar(mMenuItemId);
         }
 
         @Override
         public void onAction(Object actionData) {
-            // TODO(ramyasharma): Add logging metric to track cancel actions.
-            // Do nothing.
+            switch (mMenuItemId) {
+                case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
+                    RecordHistogram.recordEnumeratedHistogram(INFOBAR_HISTOGRAM,
+                            INFOBAR_SNACKBAR_CANCEL_ALWAYS, INFOBAR_HISTOGRAM_BOUNDARY);

[Ilya Sherman, 2017/05/10 07:10:20]

Optional nit: There's a lot of repetition of these two lines in this file.  I'd
recommend extracting a small wrapper function for readability, that you'd call
like recordInfobarAction(INFOBAR_SNACKBAR_CANCEL_ALWAYS)

[ramyasharma, 2017/05/10 09:54:52]

Thanks for the idea. Done.

+                    return;
+                case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
+                    RecordHistogram.recordEnumeratedHistogram(INFOBAR_HISTOGRAM,
+                            INFOBAR_SNACKBAR_CANCEL_NEVER, INFOBAR_HISTOGRAM_BOUNDARY);
+                    return;
+                case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
+                    RecordHistogram.recordEnumeratedHistogram(INFOBAR_HISTOGRAM,
+                            INFOBAR_SNACKBAR_CANCEL_NEVER_SITE, INFOBAR_HISTOGRAM_BOUNDARY);
+                    return;
+            }
         }
     };
 
     @CalledByNative
     private static InfoBar create(int initialStep, String sourceLanguageCode,
             String targetLanguageCode, boolean alwaysTranslate, boolean triggeredFromMenu,
             String[] languages, String[] codes) {
+        RecordHistogram.recordEnumeratedHistogram(
+                INFOBAR_HISTOGRAM, INFOBAR_IMPRESSION, INFOBAR_HISTOGRAM_BOUNDARY);
         return new TranslateCompactInfoBar(initialStep, sourceLanguageCode, targetLanguageCode,
                 alwaysTranslate, triggeredFromMenu, languages, codes);
     }
 
     TranslateCompactInfoBar(int initialStep, String sourceLanguageCode, String targetLanguageCode,
             boolean alwaysTranslate, boolean triggeredFromMenu, String[] languages,
             String[] codes) {
         super(R.drawable.infobar_translate_compact, null, null);
         mInitialStep = initialStep;
         mOptions = TranslateOptions.create(sourceLanguageCode, targetLanguageCode, languages, codes,
@@ skipping 19 matching lines @@
             mTabLayout.getTabAt(TARGET_TAB_INDEX).select();
             mTabLayout.showProgressBarOnTab(TARGET_TAB_INDEX);
         }
 
         mTabLayout.addOnTabSelectedListener(this);
 
         mMenuButton = (TintedImageButton) content.findViewById(R.id.translate_infobar_menu_button);
         mMenuButton.setOnClickListener(new OnClickListener() {
             @Override
             public void onClick(View v) {
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_OPTIONS, INFOBAR_HISTOGRAM_BOUNDARY);
                 initMenuHelper(TranslateMenu.MENU_OVERFLOW);
                 mOverflowMenuHelper.show(TranslateMenu.MENU_OVERFLOW);
             }
         });
 
         parent.addContent(content, 1.0f);
     }
 
     private void initMenuHelper(int menuType) {
         switch (menuType) {
@@ skipping 49 matching lines @@
     @Override
     protected void onNativeDestroyed() {
         mNativeTranslateInfoBarPtr = 0;
         super.onNativeDestroyed();
     }
 
     @Override
     public void onTabSelected(TabLayout.Tab tab) {
         switch (tab.getPosition()) {
             case SOURCE_TAB_INDEX:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_REVERT, INFOBAR_HISTOGRAM_BOUNDARY);
                 onButtonClicked(ActionType.TRANSLATE_SHOW_ORIGINAL);
                 return;
             case TARGET_TAB_INDEX:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_TRANSLATE, INFOBAR_HISTOGRAM_BOUNDARY);
+                RecordHistogram.recordSparseSlowlyHistogram(
+                        INFOBAR_HISTOGRAM_TRANSLATE_LANGUAGE, mOptions.targetLanguage.hashCode());
                 startTranslating(TARGET_TAB_INDEX);
                 return;
             default:
                 assert false : "Unexpected Tab Index";
         }
     }
 
     @Override
     public void onTabUnselected(TabLayout.Tab tab) {}
 
     @Override
     public void onTabReselected(TabLayout.Tab tab) {}
 
     @Override
     public void onOverflowMenuItemClicked(int itemId) {
         switch (itemId) {
             case TranslateMenu.ID_OVERFLOW_MORE_LANGUAGE:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_MORE_LANGUAGES, INFOBAR_HISTOGRAM_BOUNDARY);
                 initMenuHelper(TranslateMenu.MENU_TARGET_LANGUAGE);
                 mLanguageMenuHelper.show(TranslateMenu.MENU_TARGET_LANGUAGE);
                 return;
             case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_ALWAYS_TRANSLATE, INFOBAR_HISTOGRAM_BOUNDARY);
+                RecordHistogram.recordSparseSlowlyHistogram(
+                        INFOBAR_HISTOGRAM_ALWAYS_TRANSLATE_LANGUAGE,
+                        mOptions.sourceLanguageCode().hashCode());
                 // Only show snackbar when "Always Translate" is enabled.
                 if (!mOptions.alwaysTranslateLanguageState()) {
                     createAndShowSnackbar(
                             getContext().getString(R.string.translate_snackbar_always_translate,
                                     mOptions.sourceLanguageName(), mOptions.targetLanguageName()),
                             Snackbar.UMA_TRANSLATE_ALWAYS, itemId);
                 } else {
                     handleTranslateOptionPostSnackbar(itemId);
                 }
                 return;
             case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_NEVER_TRANSLATE, INFOBAR_HISTOGRAM_BOUNDARY);
+                RecordHistogram.recordSparseSlowlyHistogram(
+                        INFOBAR_HISTOGRAM_NEVER_TRANSLATE_LANGUAGE,
+                        mOptions.sourceLanguageCode().hashCode());
                 createAndShowSnackbar(
                         getContext().getString(R.string.translate_snackbar_language_never,
                                 mOptions.sourceLanguageName()),
                         Snackbar.UMA_TRANSLATE_NEVER, itemId);
                 return;
             case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
+                RecordHistogram.recordEnumeratedHistogram(INFOBAR_HISTOGRAM,
+                        INFOBAR_NEVER_TRANSLATE_SITE, INFOBAR_HISTOGRAM_BOUNDARY);
                 createAndShowSnackbar(
                         getContext().getString(R.string.translate_snackbar_site_never),
                         Snackbar.UMA_TRANSLATE_NEVER_SITE, itemId);
                 return;
             case TranslateMenu.ID_OVERFLOW_NOT_THIS_LANGUAGE:
+                RecordHistogram.recordEnumeratedHistogram(
+                        INFOBAR_HISTOGRAM, INFOBAR_PAGE_NOT_IN, INFOBAR_HISTOGRAM_BOUNDARY);
                 initMenuHelper(TranslateMenu.MENU_SOURCE_LANGUAGE);
                 mLanguageMenuHelper.show(TranslateMenu.MENU_SOURCE_LANGUAGE);
                 return;
             default:
                 assert false : "Unexpected overflow menu code";
         }
     }
 
     @Override
     public void onTargetMenuItemClicked(String code) {
         // Reset target code in both UI and native.
         if (mOptions.setTargetLanguage(code)) {
+            RecordHistogram.recordSparseSlowlyHistogram(INFOBAR_HISTOGRAM_MORE_LANGUAGES_LANGUAGE,
+                    mOptions.targetLanguageCode().hashCode());
             nativeApplyStringTranslateOption(
                     mNativeTranslateInfoBarPtr, TranslateOption.TARGET_CODE, code);
             // Adjust UI.
             mTabLayout.replaceTabTitle(TARGET_TAB_INDEX, mOptions.getRepresentationFromCode(code));
             startTranslating(mTabLayout.getSelectedTabPosition());
         }
     }
 
     @Override
     public void onSourceMenuItemClicked(String code) {
         // Reset source code in both UI and native.
         if (mOptions.setSourceLanguage(code)) {
+            RecordHistogram.recordSparseSlowlyHistogram(INFOBAR_HISTOGRAM_PAGE_NOT_IN_LANGUAGE,
+                    mOptions.sourceLanguageCode().hashCode());
             nativeApplyStringTranslateOption(
                     mNativeTranslateInfoBarPtr, TranslateOption.SOURCE_CODE, code);
             // Adjust UI.
             mTabLayout.replaceTabTitle(SOURCE_TAB_INDEX, mOptions.getRepresentationFromCode(code));
             startTranslating(mTabLayout.getSelectedTabPosition());
         }
     }
 
     private void createAndShowSnackbar(String title, int umaType, int itemId) {
         if (getSnackbarManager() == null) {
@@ skipping 26 matching lines @@
                         mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE_SITE, true);
                 return;
         }
     }
 
     private native void nativeApplyStringTranslateOption(
             long nativeTranslateCompactInfoBar, int option, String value);
     private native void nativeApplyBoolTranslateOption(
             long nativeTranslateCompactInfoBar, int option, boolean value);
 }