Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.cc

Issue 2873043002: VrShell: Add test for fullscreen transitions. (Closed)
Patch Set: rebase to use debug id enum instead of name one I created Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.cc b/chrome/browser/android/vr_shell/ui_scene_manager.cc
index 32efa09a4e6ab84ebb23c085b7020add7e804e47..ce3affe292d4f9e94d261e6b537fc0581ddd96f5 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.cc
@@ -163,6 +163,7 @@ void UiSceneManager::CreateSystemIndicators() {
// TODO(acondor): Make constants for sizes and positions once the UX for the
// indicators is defined.
element = base::MakeUnique<AudioCaptureIndicator>(512);
+ element->set_debug_id(kAudioCaptureIndicator);
element->set_id(AllocateId());
element->set_translation({-0.3, 0.8, -kContentDistance + 0.1});
element->set_size({0.5, 0, 1});
@@ -171,6 +172,7 @@ void UiSceneManager::CreateSystemIndicators() {
scene_->AddUiElement(std::move(element));
element = base::MakeUnique<VideoCaptureIndicator>(512);
+ element->set_debug_id(kVideoCaptureIndicator);
element->set_id(AllocateId());
element->set_translation({0.3, 0.8, -kContentDistance + 0.1});
element->set_size({0.5, 0, 1});
@@ -191,6 +193,7 @@ void UiSceneManager::CreateContentQuad() {
std::unique_ptr<UiElement> element;
element = base::MakeUnique<UiElement>();
+ element->set_debug_id(kContentQuad);
element->set_id(AllocateId());
element->set_fill(vr_shell::Fill::CONTENT);
element->set_size({kContentWidth, kContentHeight, 1});
@@ -221,6 +224,7 @@ void UiSceneManager::CreateBackground() {
// Floor.
element = base::MakeUnique<UiElement>();
+ element->set_debug_id(kFloor);
element->set_id(AllocateId());
element->set_size({kSceneSize, kSceneSize, 1.0});
element->set_translation({0.0, -kSceneHeight / 2, 0.0});
@@ -234,6 +238,7 @@ void UiSceneManager::CreateBackground() {
// Ceiling.
element = base::MakeUnique<UiElement>();
+ element->set_debug_id(kCeiling);
element->set_id(AllocateId());
element->set_fill(vr_shell::Fill::OPAQUE_GRADIENT);
element->set_size({kSceneSize, kSceneSize, 1.0});
@@ -248,6 +253,7 @@ void UiSceneManager::CreateBackground() {
// Floor grid.
element = base::MakeUnique<UiElement>();
+ element->set_debug_id(kGrid);
element->set_id(AllocateId());
element->set_fill(vr_shell::Fill::GRID_GRADIENT);
element->set_size({kSceneSize, kSceneSize, 1.0});
@@ -269,6 +275,7 @@ void UiSceneManager::CreateBackground() {
void UiSceneManager::CreateUrlBar() {
// TODO(cjgrant): Incorporate final size and position.
auto url_bar = base::MakeUnique<UrlBar>(512);
+ url_bar->set_debug_id(kBrowserBar);
url_bar->set_id(AllocateId());
url_bar->set_translation({0, kUrlBarVerticalOffset, -kUrlBarDistance});
url_bar->set_size({kUrlBarWidth, kUrlBarHeight, 1});
@@ -279,6 +286,7 @@ void UiSceneManager::CreateUrlBar() {
scene_->AddUiElement(std::move(url_bar));
auto indicator = base::MakeUnique<LoadingIndicator>(256);
+ indicator->set_debug_id(kLoadingIndicator);
indicator->set_id(AllocateId());
indicator->set_translation({0, 0, kLoadingIndicatorOffset});
indicator->set_size({kLoadingIndicatorWidth, kLoadingIndicatorHeight, 1});

Powered by Google App Engine
This is Rietveld 408576698