Issue 287303002: Call EmbeddedWorkerDevToolsManager::WorkerDestroyed from SharedWorkerHost::WorkerContextClosed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287303002: Call EmbeddedWorkerDevToolsManager::WorkerDestroyed from SharedWorkerHost::WorkerContextClosed. (Closed)

Created:
6 years, 7 months ago by horo

Modified:
6 years, 7 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Call EmbeddedWorkerDevToolsManager::WorkerDestroyed from SharedWorkerHost::WorkerContextClosed. If SharedWorkerHost's closed flag is true SharedWorkerServiceImpl::FindSharedWorkerHost() doesn't match the host. So two SharedWorkerHosts of same SharedWorkerInstance could be created. But EmbeddedWorkerDevToolsManager can't handle two SharedWorkerHosts of same SharedWorkerInstance. So we have to remove instance from EmbeddedWorkerDevToolsManager when WorkerContextClosed is called. BUG=374387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271463