Issue 2873027: Consistently increase the reference count when calling GetDefaultNSSKeySlot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2873027: Consistently increase the reference count when calling GetDefaultNSSKeySlot (Closed)

Created:
10 years, 5 months ago by davidben

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone, agl

CC:
chromium-reviews, brettw-cc_chromium.org

Visibility:
Public.

Description

Consistently increase the reference count when calling GetDefaultNSSKeySlot We're actually freeing the key slot multiple times on Chrome OS. Also documented the requirement to PK11_FreeSlot in the function declaration. We probably want to add some sort of scoped_refptr-like thing, but for now this function is only used in one place anyway. R=cmasone BUG=47587 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51091