ios/web/web_state/ui/crw_web_controller.mm - Issue 2873023002: Call WebStateObserver::ProvisionalNavigationStarted for state navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2873023002: Call WebStateObserver::ProvisionalNavigationStarted for state navigations (Closed)

Patch Set: Rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 835be5ea5fd887c005feda5c46e9d193c16995d6..20eb3c3c788ee8dff294274e37704a2ddcea7bc6 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -1339,6 +1339,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

- (void)pushStateWithPageURL:(const GURL&)pageURL

stateObject:(NSString*)stateObject

transition:(ui::PageTransition)transition {

+ _webStateImpl->OnProvisionalNavigationStarted(pageURL);

[[self sessionController] pushNewItemWithURL:pageURL

stateObject:stateObject

transition:transition];

@@ -1351,6 +1352,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

- (void)replaceStateWithPageURL:(const GURL&)pageURL

stateObject:(NSString*)stateObject {

+ _webStateImpl->OnProvisionalNavigationStarted(pageURL);

[[self sessionController] updateCurrentItemWithURL:pageURL

stateObject:stateObject];

std::unique_ptr<web::NavigationContext> context =

« no previous file with comments | « ios/web/web_state/navigation_callbacks_inttest.mm ('k') | no next file » | no next file with comments »