Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: runtime/observatory/lib/src/elements/objectpool_view.dart

Issue 2873013004: Omnibus Observatory UI fixes: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/objectpool_view.dart
diff --git a/runtime/observatory/lib/src/elements/objectpool_view.dart b/runtime/observatory/lib/src/elements/objectpool_view.dart
index 86204397938a9b1e867eea8880d9f77402963b06..a68aadea5449b94765d89bd5fd310e050748ad7c 100644
--- a/runtime/observatory/lib/src/elements/objectpool_view.dart
+++ b/runtime/observatory/lib/src/elements/objectpool_view.dart
@@ -50,7 +50,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository _reachableSizes;
M.InboundReferencesRepository _references;
M.RetainingPathRepository _retainingPaths;
- M.InstanceRepository _instances;
+ M.ObjectRepository _objects;
M.VMRef get vm => _vm;
M.IsolateRef get isolate => _isolate;
@@ -68,7 +68,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
M.ReachableSizeRepository reachableSizes,
M.InboundReferencesRepository references,
M.RetainingPathRepository retainingPaths,
- M.InstanceRepository instances,
+ M.ObjectRepository objects,
{RenderingQueue queue}) {
assert(vm != null);
assert(isolate != null);
@@ -80,7 +80,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
assert(reachableSizes != null);
assert(references != null);
assert(retainingPaths != null);
- assert(instances != null);
+ assert(objects != null);
ObjectPoolViewElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._vm = vm;
@@ -93,7 +93,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
e._reachableSizes = reachableSizes;
e._references = references;
e._retainingPaths = retainingPaths;
- e._instances = instances;
+ e._objects = objects;
return e;
}
@@ -133,7 +133,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
new HeadingElement.h2()..text = 'ObjectPool',
new HRElement(),
new ObjectCommonElement(_isolate, _pool, _retainedSizes,
- _reachableSizes, _references, _retainingPaths, _instances,
+ _reachableSizes, _references, _retainingPaths, _objects,
queue: _r.queue),
new HRElement(),
new HeadingElement.h3()..text = 'entries (${_pool.entries.length})',
@@ -160,7 +160,7 @@ class ObjectPoolViewElement extends HtmlElement implements Renderable {
List<Element> _createEntry(M.ObjectPoolEntry entry) {
switch (entry.kind) {
case M.ObjectPoolEntryKind.object:
- return [anyRef(_isolate, entry.asObject, _instances, queue: _r.queue)];
+ return [anyRef(_isolate, entry.asObject, _objects, queue: _r.queue)];
case M.ObjectPoolEntryKind.immediate:
return [
new SpanElement()
« no previous file with comments | « runtime/observatory/lib/src/elements/object_view.dart ('k') | runtime/observatory/lib/src/elements/objectstore_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698