Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: cc/paint/discardable_image_store.h

Issue 2873003002: Add stable id to PaintImage. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/paint/discardable_image_map_unittest.cc ('k') | cc/paint/discardable_image_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/paint/discardable_image_store.h
diff --git a/cc/paint/discardable_image_store.h b/cc/paint/discardable_image_store.h
index 1c26e79e57653e22e29435d7492ba40f4fceb81c..426785c529a5acccf814c36d123a2d0212f9b049 100644
--- a/cc/paint/discardable_image_store.h
+++ b/cc/paint/discardable_image_store.h
@@ -44,6 +44,13 @@ class CC_PAINT_EXPORT DiscardableImageStore {
std::unique_ptr<PaintTrackingCanvas> canvas_;
std::vector<std::pair<DrawImage, gfx::Rect>>* image_set_;
base::flat_map<ImageId, gfx::Rect>* image_id_to_rect_;
+ // This is currently used for images that come from shaders. We don't know
+ // what the stable id is, but since the completion and animation states are
+ // both unknown, this value doesn't matter as it won't be used in checker
+ // imaging anyway. Keep this value the same to avoid id churn.
+ // TODO(vmpstr): Remove this when we can add paint images into shaders
+ // directly.
+ PaintImage::Id unknown_stable_id_;
};
} // namespace cc
« no previous file with comments | « cc/paint/discardable_image_map_unittest.cc ('k') | cc/paint/discardable_image_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698