Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 2873003002: Add stable id to PaintImage. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) { 157 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecord) {
158 lazy_decoder_->SetData(data_, true); 158 lazy_decoder_->SetData(data_, true);
159 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 159 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
160 ASSERT_TRUE(image); 160 ASSERT_TRUE(image);
161 EXPECT_EQ(1, image->width()); 161 EXPECT_EQ(1, image->width());
162 EXPECT_EQ(1, image->height()); 162 EXPECT_EQ(1, image->height());
163 163
164 PaintRecorder recorder; 164 PaintRecorder recorder;
165 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 165 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
166 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0); 166 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)),
167 0, 0);
167 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 168 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
168 EXPECT_EQ(0, decode_request_count_); 169 EXPECT_EQ(0, decode_request_count_);
169 170
170 canvas_->drawPicture(record); 171 canvas_->drawPicture(record);
171 EXPECT_EQ(0, decode_request_count_); 172 EXPECT_EQ(0, decode_request_count_);
172 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0)); 173 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));
173 } 174 }
174 175
175 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecordProgressive) { 176 TEST_F(DeferredImageDecoderTest, drawIntoPaintRecordProgressive) {
176 RefPtr<SharedBuffer> partial_data = 177 RefPtr<SharedBuffer> partial_data =
177 SharedBuffer::Create(data_->Data(), data_->size() - 10); 178 SharedBuffer::Create(data_->Data(), data_->size() - 10);
178 179
179 // Received only half the file. 180 // Received only half the file.
180 lazy_decoder_->SetData(partial_data, false); 181 lazy_decoder_->SetData(partial_data, false);
181 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 182 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
182 ASSERT_TRUE(image); 183 ASSERT_TRUE(image);
183 PaintRecorder recorder; 184 PaintRecorder recorder;
184 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 185 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
186 PaintImage::Id stable_id = PaintImage::GetNextId();
185 temp_canvas->drawImage( 187 temp_canvas->drawImage(
186 PaintImage(std::move(image), PaintImage::AnimationType::STATIC, 188 PaintImage(stable_id, std::move(image), PaintImage::AnimationType::STATIC,
187 PaintImage::CompletionState::PARTIALLY_DONE), 189 PaintImage::CompletionState::PARTIALLY_DONE),
188 0, 0); 190 0, 0);
189 canvas_->drawPicture(recorder.finishRecordingAsPicture()); 191 canvas_->drawPicture(recorder.finishRecordingAsPicture());
190 192
191 // Fully received the file and draw the PaintRecord again. 193 // Fully received the file and draw the PaintRecord again.
192 lazy_decoder_->SetData(data_, true); 194 lazy_decoder_->SetData(data_, true);
193 image = lazy_decoder_->CreateFrameAtIndex(0); 195 image = lazy_decoder_->CreateFrameAtIndex(0);
194 ASSERT_TRUE(image); 196 ASSERT_TRUE(image);
195 temp_canvas = recorder.beginRecording(100, 100); 197 temp_canvas = recorder.beginRecording(100, 100);
196 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0); 198 temp_canvas->drawImage(PaintImage(stable_id, std::move(image)), 0, 0);
197 canvas_->drawPicture(recorder.finishRecordingAsPicture()); 199 canvas_->drawPicture(recorder.finishRecordingAsPicture());
198 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0)); 200 EXPECT_EQ(SkColorSetARGB(255, 255, 255, 255), bitmap_.getColor(0, 0));
199 } 201 }
200 202
201 static void RasterizeMain(PaintCanvas* canvas, sk_sp<PaintRecord> record) { 203 static void RasterizeMain(PaintCanvas* canvas, sk_sp<PaintRecord> record) {
202 canvas->drawPicture(record); 204 canvas->drawPicture(record);
203 } 205 }
204 206
205 TEST_F(DeferredImageDecoderTest, decodeOnOtherThread) { 207 TEST_F(DeferredImageDecoderTest, decodeOnOtherThread) {
206 lazy_decoder_->SetData(data_, true); 208 lazy_decoder_->SetData(data_, true);
207 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 209 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
208 ASSERT_TRUE(image); 210 ASSERT_TRUE(image);
209 EXPECT_EQ(1, image->width()); 211 EXPECT_EQ(1, image->width());
210 EXPECT_EQ(1, image->height()); 212 EXPECT_EQ(1, image->height());
211 213
212 PaintRecorder recorder; 214 PaintRecorder recorder;
213 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 215 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
214 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0); 216 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)),
217 0, 0);
215 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 218 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
216 EXPECT_EQ(0, decode_request_count_); 219 EXPECT_EQ(0, decode_request_count_);
217 220
218 // Create a thread to rasterize PaintRecord. 221 // Create a thread to rasterize PaintRecord.
219 std::unique_ptr<WebThread> thread = 222 std::unique_ptr<WebThread> thread =
220 Platform::Current()->CreateThread("RasterThread"); 223 Platform::Current()->CreateThread("RasterThread");
221 thread->GetWebTaskRunner()->PostTask( 224 thread->GetWebTaskRunner()->PostTask(
222 BLINK_FROM_HERE, 225 BLINK_FROM_HERE,
223 CrossThreadBind(&RasterizeMain, CrossThreadUnretained(canvas_.get()), 226 CrossThreadBind(&RasterizeMain, CrossThreadUnretained(canvas_.get()),
224 record)); 227 record));
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0); 301 sk_sp<SkImage> image = lazy_decoder_->CreateFrameAtIndex(0);
299 ASSERT_TRUE(image); 302 ASSERT_TRUE(image);
300 EXPECT_EQ(decoded_size_.Width(), image->width()); 303 EXPECT_EQ(decoded_size_.Width(), image->width());
301 EXPECT_EQ(decoded_size_.Height(), image->height()); 304 EXPECT_EQ(decoded_size_.Height(), image->height());
302 305
303 UseMockImageDecoderFactory(); 306 UseMockImageDecoderFactory();
304 307
305 // The following code should not fail any assert. 308 // The following code should not fail any assert.
306 PaintRecorder recorder; 309 PaintRecorder recorder;
307 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100); 310 PaintCanvas* temp_canvas = recorder.beginRecording(100, 100);
308 temp_canvas->drawImage(PaintImage(std::move(image)), 0, 0); 311 temp_canvas->drawImage(PaintImage(PaintImage::GetNextId(), std::move(image)),
312 0, 0);
309 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture(); 313 sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
310 EXPECT_EQ(0, decode_request_count_); 314 EXPECT_EQ(0, decode_request_count_);
311 canvas_->drawPicture(record); 315 canvas_->drawPicture(record);
312 EXPECT_EQ(1, decode_request_count_); 316 EXPECT_EQ(1, decode_request_count_);
313 } 317 }
314 318
315 TEST_F(DeferredImageDecoderTest, smallerFrameCount) { 319 TEST_F(DeferredImageDecoderTest, smallerFrameCount) {
316 frame_count_ = 1; 320 frame_count_ = 1;
317 lazy_decoder_->SetData(data_, false); 321 lazy_decoder_->SetData(data_, false);
318 EXPECT_EQ(frame_count_, lazy_decoder_->FrameCount()); 322 EXPECT_EQ(frame_count_, lazy_decoder_->FrameCount());
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 SharedBuffer::Create(data_->Data(), data_->size()); 387 SharedBuffer::Create(data_->Data(), data_->size());
384 EXPECT_EQ(original_data->size(), data_->size()); 388 EXPECT_EQ(original_data->size(), data_->size());
385 lazy_decoder_->SetData(original_data, false); 389 lazy_decoder_->SetData(original_data, false);
386 RefPtr<SharedBuffer> new_data = lazy_decoder_->Data(); 390 RefPtr<SharedBuffer> new_data = lazy_decoder_->Data();
387 EXPECT_EQ(original_data->size(), new_data->size()); 391 EXPECT_EQ(original_data->size(), new_data->size());
388 EXPECT_EQ(0, std::memcmp(original_data->Data(), new_data->Data(), 392 EXPECT_EQ(0, std::memcmp(original_data->Data(), new_data->Data(),
389 new_data->size())); 393 new_data->size()));
390 } 394 }
391 395
392 } // namespace blink 396 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/DragImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/Image.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698