Issue 2873003: Disable caching of failed DNS lookups.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2873003: Disable caching of failed DNS lookups. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by eroman

Modified:
4 years ago

Reviewers:
Mike Belshe, omattos

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable caching of failed DNS lookups. This is causing problems on network changes, since we don't have a reliable signal for telling when DNS is back up (so we aren't able to flush the cache properly). This will regress bug 1672, filed 46821 to address that. BUG=46821 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50141

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/base/host_resolver_impl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: win mac linux

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

omattos

How will this impact load times of pages with lots of resources from an invalid ...

4 years, 11 months ago (2010-06-17 21:49:44 UTC) #4

eroman

4 years, 11 months ago (2010-06-17 21:55:58 UTC) #5

Yes, this will hurt performance for certain cases. The most notable one is 46821
(which can mean the difference between say a 2 second load time versus a 30
second load time).

Expand Messages | Collapse Messages