Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: content/browser/download/parallel_download_job.cc

Issue 2872943003: Reduce unnecessary download interruptions due to parallel requests (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/parallel_download_job.cc
diff --git a/content/browser/download/parallel_download_job.cc b/content/browser/download/parallel_download_job.cc
index 5f282c3536dc091899a7ad58f328480ef4cc4f8f..e83df49104f09f0bc824521a7f51cf6a5268da14 100644
--- a/content/browser/download/parallel_download_job.cc
+++ b/content/browser/download/parallel_download_job.cc
@@ -128,21 +128,6 @@ void ParallelDownloadJob::OnByteStreamReady(
}
}
-void ParallelDownloadJob::OnServerResponseError(
- DownloadWorker* worker,
- DownloadInterruptReason reason) {
- // TODO(xingliu): Consider to let the original request to cover the full
- // content if the sub-requests get invalid response. Consider retry on certain
- // error.
- if (worker->length() == DownloadSaveInfo::kLengthFullContent &&
- reason ==
- DownloadInterruptReason::DOWNLOAD_INTERRUPT_REASON_SERVER_NO_RANGE) {
- SetPotentialFileLength(worker->offset());
xingliu 2017/05/10 01:40:17 nit: Shall we remove DownloadJob::SetPotentialFile
qinmin 2017/05/10 17:47:24 Done.
- return;
- }
- DownloadJob::Interrupt(reason);
-}
-
void ParallelDownloadJob::BuildParallelRequests() {
DCHECK(!requests_sent_);
DCHECK(!is_paused());

Powered by Google App Engine
This is Rietveld 408576698