Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2872943002: [SimpleCache] Prefetch stream 1 so that the first read is faster

Created:
3 years, 7 months ago by jkarlin
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SimpleCache -- INCOMPLETE] Prefetch stream 1 so that the first read is faster 90% of cache reads are < 32KB. If we prefetch stream 1 when opening an entry, then for cache hits, we'd make 90% of the entry's reads synchronous. There is a slight additional cost to cache misses but it's just a single read call. BUG=719979

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -9 lines) Patch
M net/disk_cache/simple/simple_entry_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.h View 2 chunks +6 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 4 chunks +35 lines, -4 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 5 (4 generated)
jkarlin
3 years, 7 months ago (2017-05-09 15:56:45 UTC) #3
https://codereview.chromium.org/2872943002/diff/1/net/disk_cache/simple/simpl...
File net/disk_cache/simple/simple_synchronous_entry.cc (right):

https://codereview.chromium.org/2872943002/diff/1/net/disk_cache/simple/simpl...
net/disk_cache/simple/simple_synchronous_entry.cc:1157: if
(out_entry_stat->sparse_data_size() == 0 &&
The bits in this conditional are completely broken. Mostly cut and pastes that I
intended to hack into something.

Powered by Google App Engine
This is Rietveld 408576698