Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: tools/perf/benchmarks/oortonline.py

Issue 2872923002: Add ownership info for v8 benchmarks (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 import page_sets 7 import page_sets
8 8
9 from core import perf_benchmark 9 from core import perf_benchmark
10 from telemetry import benchmark 10 from telemetry import benchmark
(...skipping 16 matching lines...) Expand all
27 scores = tab.EvaluateJavaScript('window.benchmarkScore') 27 scores = tab.EvaluateJavaScript('window.benchmarkScore')
28 for score in scores: 28 for score in scores:
29 valid = score['valid'] 29 valid = score['valid']
30 if valid: 30 if valid:
31 results.AddValue(scalar.ScalarValue( 31 results.AddValue(scalar.ScalarValue(
32 results.current_page, score['name'], 'score', score['score'], 32 results.current_page, score['name'], 'score', score['score'],
33 important=True, improvement_direction=improvement_direction.UP)) 33 important=True, improvement_direction=improvement_direction.UP))
34 34
35 35
36 @benchmark.Disabled('android') 36 @benchmark.Disabled('android')
37 @benchmark.Owner(emails=['ulan@chromium.org'])
37 class OortOnline(perf_benchmark.PerfBenchmark): 38 class OortOnline(perf_benchmark.PerfBenchmark):
38 """OortOnline benchmark that measures WebGL and V8 performance. 39 """OortOnline benchmark that measures WebGL and V8 performance.
39 URL: http://oortonline.gl/#run 40 URL: http://oortonline.gl/#run
40 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html 41 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html
41 """ 42 """
42 test = _OortOnlineMeasurement 43 test = _OortOnlineMeasurement
43 44
44 @classmethod 45 @classmethod
45 def Name(cls): 46 def Name(cls):
46 return 'oortonline' 47 return 'oortonline'
47 48
48 def CreateStorySet(self, options): 49 def CreateStorySet(self, options):
49 return page_sets.OortOnlinePageSet() 50 return page_sets.OortOnlinePageSet()
50 51
51 52
52 @benchmark.Disabled('win') 53 @benchmark.Disabled('win')
54 @benchmark.Owner(emails=['ulan@chromium.org'])
53 class OortOnlineTBMv2(perf_benchmark.PerfBenchmark): 55 class OortOnlineTBMv2(perf_benchmark.PerfBenchmark):
54 """OortOnline benchmark that measures WebGL and V8 performance. 56 """OortOnline benchmark that measures WebGL and V8 performance.
55 URL: http://oortonline.gl/#run 57 URL: http://oortonline.gl/#run
56 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html 58 Info: http://v8project.blogspot.de/2015/10/jank-busters-part-one.html
57 """ 59 """
58 60
59 # Report only V8-specific and overall renderer memory values. Note that 61 # Report only V8-specific and overall renderer memory values. Note that
60 # detailed values reported by the OS (such as native heap) are excluded. 62 # detailed values reported by the OS (such as native heap) are excluded.
61 _V8_AND_OVERALL_MEMORY_RE = re.compile( 63 _V8_AND_OVERALL_MEMORY_RE = re.compile(
62 r'renderer_processes:' 64 r'renderer_processes:'
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 def Name(cls): 104 def Name(cls):
103 return 'oortonline_tbmv2' 105 return 'oortonline_tbmv2'
104 106
105 @classmethod 107 @classmethod
106 def ValueCanBeAddedPredicate(cls, value, _): 108 def ValueCanBeAddedPredicate(cls, value, _):
107 if 'memory:chrome' in value.name: 109 if 'memory:chrome' in value.name:
108 return bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name)) 110 return bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name))
109 if 'animation ' in value.name: 111 if 'animation ' in value.name:
110 return 'throughput' in value.name or 'frameTimeDiscrepancy' in value.name 112 return 'throughput' in value.name or 'frameTimeDiscrepancy' in value.name
111 return 'v8' in value.name 113 return 'v8' in value.name
OLDNEW
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698