Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: pkg/kernel/test/closures/suite.dart

Issue 2872903005: Rework DillLoader to allow adding multiple dills. (Closed)
Patch Set: Updates for review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/test/closures/suite.dart
diff --git a/pkg/kernel/test/closures/suite.dart b/pkg/kernel/test/closures/suite.dart
index dd4419d4d8433f2f06bb5ce4416c1d5d7d47a1b2..3ce1d664e709e02f641a4f325229eee798cc77b0 100644
--- a/pkg/kernel/test/closures/suite.dart
+++ b/pkg/kernel/test/closures/suite.dart
@@ -60,7 +60,8 @@ class ClosureConversionContext extends ChainContext {
Future<Program> loadPlatform() async {
Uri sdk = await computePatchedSdk();
- return loadProgramFromBinary(sdk.resolve('platform.dill').toFilePath());
+ String platformPath = sdk.resolve('platform.dill').toFilePath();
+ return loadProgramFromBinary(platformPath);
ahe 2017/05/11 10:09:49 Why this change?
scheglov 2017/05/11 15:53:11 I will roll this back.
}
static Future<ClosureConversionContext> create(
@@ -93,9 +94,7 @@ class FastaCompile
Program platform = await context.loadPlatform();
Ticker ticker = new Ticker();
DillTarget dillTarget = new DillTarget(ticker, context.uriTranslator);
- dillTarget.loader
- ..input = Uri.parse("org.dartlang:platform") // Make up a name.
- ..setProgram(platform);
+ dillTarget.loader.appendLibraries(platform);
KernelTarget sourceTarget = new KernelTarget(PhysicalFileSystem.instance,
dillTarget, context.uriTranslator, context.strongMode);

Powered by Google App Engine
This is Rietveld 408576698