Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_target.dart

Issue 2872903005: Rework DillLoader to allow adding multiple dills. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/dill/dill_target.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_target.dart b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
index 4e53c689b4a8f9b47f3d53314330587d58b78401..c8bad3bd5a7f177d7d05b2053f4abcbedcea7568 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_target.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
@@ -37,11 +37,7 @@ class DillTarget extends TargetImplementation {
}
void read(Uri uri) {
- if (loader.input == null) {
- loader.input = uri;
- } else {
- inputError(uri, -1, "Can only read one dill file.");
- }
+ inputError(uri, -1, "Use appendDillForProgram() instead.");
Siggi Cherem (dart-lang) 2017/05/09 20:14:30 should this be internalError("not implemented") in
scheglov 2017/05/09 20:32:21 Done.
}
Future<Null> writeProgram(Uri uri) {
@@ -49,7 +45,7 @@ class DillTarget extends TargetImplementation {
}
Future<Null> writeOutline(Uri uri) async {
- if (loader.input == null) return null;
+ if (loader.program == null) return null;
await loader.buildOutlines();
isLoaded = true;
return null;

Powered by Google App Engine
This is Rietveld 408576698