Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Issue 2872903003: Get some more strong mode type inference tests to pass (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get some more strong mode type inference tests to pass The functionality necessary to get these tests to pass is actually already present; they just needed expectations files, and in one case, a main() method. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ea6b301e816d4e943ad94cb7227a62759247a8c6

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-09 13:07:04 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-09 13:57:13 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-09 15:36:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea6b301e816d4e943ad94cb7227a62759247a8c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698