Create BUILD.gn files for //media/formats.

media/formats/BUILD.gn

+# Copyright 2014 The Chromium Authors. All rights reserved.

[jrummell, 2017/05/11 17:36:15]

Since this is a new file it should be 2017.

[a.suchit2, 2017/05/12 05:54:43]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//media/media_options.gni")
+
+source_set("formats") {

[jrummell, 2017/05/11 17:36:15]

Can you add "visibility = [ "//media/*" ]" so that nobody outside of //media can
use this directly.

[jrummell, 2017/05/11 17:36:15]

Based on the compile errors, you'll need something like:
  configs += [
    "//media:media_config",
    "//media:media_implementation",
  ]
or maybe just:
  configs += [ "//media/base:base_config" ]
(as it includes the 2 above plus some others that may also be necessary).

[a.suchit2, 2017/05/12 05:54:43]

Done.

[a.suchit2, 2017/05/18 00:36:15]

Done.

+  sources = [
+    "common/offset_byte_queue.cc",
+    "common/offset_byte_queue.h",
+    "webm/webm_audio_client.cc",
+    "webm/webm_audio_client.h",
+    "webm/webm_cluster_parser.cc",
+    "webm/webm_cluster_parser.h",
+    "webm/webm_colour_parser.cc",
+    "webm/webm_colour_parser.h",
+    "webm/webm_constants.cc",
+    "webm/webm_constants.h",
+    "webm/webm_content_encodings.cc",
+    "webm/webm_content_encodings.h",
+    "webm/webm_content_encodings_client.cc",
+    "webm/webm_content_encodings_client.h",
+    "webm/webm_crypto_helpers.cc",
+    "webm/webm_crypto_helpers.h",
+    "webm/webm_info_parser.cc",
+    "webm/webm_info_parser.h",
+    "webm/webm_parser.cc",
+    "webm/webm_parser.h",
+    "webm/webm_stream_parser.cc",
+    "webm/webm_stream_parser.h",
+    "webm/webm_tracks_parser.cc",
+    "webm/webm_tracks_parser.h",
+    "webm/webm_video_client.cc",
+    "webm/webm_video_client.h",
+    "webm/webm_webvtt_parser.cc",
+    "webm/webm_webvtt_parser.h",
+  ]
+
+  deps = [
+    "//skia",

[jrummell, 2017/05/11 17:36:15]

There should also be a dependency on //base, //media/base,
//media:media_features, //media:shared_memory_support, and probably some more.
However, this is where the dependency loops get challenging. You might have to
leave some out until all the directories are done.

[a.suchit2, 2017/05/18 00:36:15]

Done.

+  ]
+
+  if (proprietary_codecs && enable_hevc_demuxing) {
+    sources += [
+      "mp4/hevc.cc",
+      "mp4/hevc.h",
+    ]
+  }
+  if (proprietary_codecs && enable_dolby_vision_demuxing) {
+    sources += [
+      "mp4/dolby_vision.cc",
+      "mp4/dolby_vision.h",
+    ]
+  }
+
+  if (proprietary_codecs) {
+    sources += [
+      "mp4/aac.cc",
+      "mp4/aac.h",
+      "mp4/avc.cc",
+      "mp4/avc.h",
+      "mp4/bitstream_converter.cc",
+      "mp4/bitstream_converter.h",
+      "mp4/box_definitions.cc",
+      "mp4/box_definitions.h",
+      "mp4/box_reader.cc",
+      "mp4/box_reader.h",
+      "mp4/es_descriptor.cc",
+      "mp4/es_descriptor.h",
+      "mp4/mp4_stream_parser.cc",
+      "mp4/mp4_stream_parser.h",
+      "mp4/sample_to_group_iterator.cc",
+      "mp4/sample_to_group_iterator.h",
+      "mp4/track_run_iterator.cc",
+      "mp4/track_run_iterator.h",
+      "mpeg/adts_constants.cc",
+      "mpeg/adts_constants.h",
+      "mpeg/adts_stream_parser.cc",
+      "mpeg/adts_stream_parser.h",
+      "mpeg/mpeg1_audio_stream_parser.cc",
+      "mpeg/mpeg1_audio_stream_parser.h",
+      "mpeg/mpeg_audio_stream_parser_base.cc",
+      "mpeg/mpeg_audio_stream_parser_base.h",
+    ]
+    if (enable_mse_mpeg2ts_stream_parser) {

[jrummell, 2017/05/11 17:36:15]

Can this be it's own block (if (proprietary_codecs &&
enable_mse_mpeg2ts_stream_parser) ...)? I find it easier to understand when
looking to see what conditions trigger a file getting compiled.

And then I guess (proprietary_codecs) should be the first block, so move the 2
above it down to here as well.

if (proprietary_codecs) ...
if (proprietary_codecs && enable_hevc_demuxing) ...
if (proprietary_codecs && enable_dolby_vision_demuxing) ...
if (proprietary_codecs && enable_mse_mpeg2ts_stream_parser) ...
if (proprietary_codecs && enable_mse_mpeg2ts_stream_parser &&
enable_hls_sample_aes) ...

[a.suchit2, 2017/05/12 05:54:43]

Done.

+      sources += [
+        "mp2t/descriptors.cc",
+        "mp2t/descriptors.h",
+        "mp2t/es_adapter_video.cc",
+        "mp2t/es_adapter_video.h",
+        "mp2t/es_parser.cc",
+        "mp2t/es_parser.h",
+        "mp2t/es_parser_adts.cc",
+        "mp2t/es_parser_adts.h",
+        "mp2t/es_parser_h264.cc",
+        "mp2t/es_parser_h264.h",
+        "mp2t/es_parser_mpeg1audio.cc",
+        "mp2t/es_parser_mpeg1audio.h",
+        "mp2t/mp2t_common.h",
+        "mp2t/mp2t_stream_parser.cc",
+        "mp2t/mp2t_stream_parser.h",
+        "mp2t/timestamp_unroller.cc",
+        "mp2t/timestamp_unroller.h",
+        "mp2t/ts_packet.cc",
+        "mp2t/ts_packet.h",
+        "mp2t/ts_section.h",
+        "mp2t/ts_section_pat.cc",
+        "mp2t/ts_section_pat.h",
+        "mp2t/ts_section_pes.cc",
+        "mp2t/ts_section_pes.h",
+        "mp2t/ts_section_pmt.cc",
+        "mp2t/ts_section_pmt.h",
+        "mp2t/ts_section_psi.cc",
+        "mp2t/ts_section_psi.h",
+      ]
+      if (enable_hls_sample_aes) {
+        sources += [
+          "mp2t/ts_section_cat.cc",
+          "mp2t/ts_section_cat.h",
+          "mp2t/ts_section_cets_ecm.cc",
+          "mp2t/ts_section_cets_ecm.h",
+          "mp2t/ts_section_cets_pssh.cc",
+          "mp2t/ts_section_cets_pssh.h",
+        ]
+      }
+    }
+  }
+}