|
|
Created:
3 years, 7 months ago by Marc Treib Modified:
3 years, 7 months ago CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionLocal NTP: Add histograms for OneGoogleBar load time
BUG=583292
Review-Url: https://codereview.chromium.org/2872813005
Cr-Commit-Position: refs/heads/master@{#470576}
Committed: https://chromium.googlesource.com/chromium/src/+/83e22f1c302dc7af075be861e90be4e23d83a355
Patch Set 1 #
Messages
Total messages: 27 (21 generated)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + sfiera@chromium.org
PTAL!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
LGTM
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + rkaplow@chromium.org
+rkaplow for histograms.xml, PTAL!
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by treib@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1494428795846460, "parent_rev": "7475d0c2ee929ce0c2fe346fd7ebb6937f89d9e3", "commit_rev": "83e22f1c302dc7af075be861e90be4e23d83a355"}
Message was sent while issue was closed.
Description was changed from ========== Local NTP: Add histograms for OneGoogleBar load time BUG=583292 ========== to ========== Local NTP: Add histograms for OneGoogleBar load time BUG=583292 Review-Url: https://codereview.chromium.org/2872813005 Cr-Commit-Position: refs/heads/master@{#470576} Committed: https://chromium.googlesource.com/chromium/src/+/83e22f1c302dc7af075be861e90b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/83e22f1c302dc7af075be861e90b... |