Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2872813005: Local NTP: Add histograms for OneGoogleBar load time (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
rkaplow, sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Local NTP: Add histograms for OneGoogleBar load time BUG=583292 Review-Url: https://codereview.chromium.org/2872813005 Cr-Commit-Position: refs/heads/master@{#470576} Committed: https://chromium.googlesource.com/chromium/src/+/83e22f1c302dc7af075be861e90be4e23d83a355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -23 lines) Patch
M chrome/browser/search/local_ntp_source.h View 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 5 chunks +38 lines, -20 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (21 generated)
Marc Treib
PTAL!
3 years, 7 months ago (2017-05-09 17:15:23 UTC) #4
sfiera
LGTM
3 years, 7 months ago (2017-05-10 14:28:28 UTC) #15
Marc Treib
+rkaplow for histograms.xml, PTAL!
3 years, 7 months ago (2017-05-10 14:39:02 UTC) #19
rkaplow
lgtm
3 years, 7 months ago (2017-05-10 14:51:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872813005/1
3 years, 7 months ago (2017-05-10 15:07:05 UTC) #24
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 15:12:34 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83e22f1c302dc7af075be861e90b...

Powered by Google App Engine
This is Rietveld 408576698