Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2591)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2872813004: Revert a change of disabling translation from context menu temporarily (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 5a7909e0c5c698a98914021b56cf0bca8845a32e..eb26154d038e8095c4502287832c56336799913c 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1203,16 +1203,16 @@ void RenderViewContextMenu::AppendPageItems() {
std::unique_ptr<translate::TranslatePrefs> prefs(
ChromeTranslateClient::CreateTranslatePrefs(
GetPrefs(browser_context_)));
- if (prefs->IsEnabled()) {
- std::string locale =
- translate::TranslateManager::GetTargetLanguage(prefs.get());
- base::string16 language =
- l10n_util::GetDisplayNameForLocale(locale, locale, true);
- menu_model_.AddItem(
- IDC_CONTENT_CONTEXT_TRANSLATE,
- l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_TRANSLATE, language));
- AddGoogleIconToLastMenuItem(&menu_model_);
- }
+ // TODO(crbug.com/711217): We should not allow to use the translate when the
+ // feature is disabled by the PolicyList.
lazyboy 2017/05/09 16:35:39 Are you referring to kTranslateEnabled policy? Giv
+ std::string locale =
+ translate::TranslateManager::GetTargetLanguage(prefs.get());
+ base::string16 language =
+ l10n_util::GetDisplayNameForLocale(locale, locale, true);
+ menu_model_.AddItem(
+ IDC_CONTENT_CONTEXT_TRANSLATE,
+ l10n_util::GetStringFUTF16(IDS_CONTENT_CONTEXT_TRANSLATE, language));
+ AddGoogleIconToLastMenuItem(&menu_model_);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698