build/android/pylib/local/device/local_device_environment.py - Issue 2872813003: Avoid crashing due to missing trace_output option in Monkey test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 2872813003: Avoid crashing due to missing trace_output option in Monkey test (Closed)

Patch Set: Addressed jbudorick's comment to check for trace_output in local_device_environment.py Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/local/device/local_device_environment.py

diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py

index 86ffc5f59daa62457dd32907593ae01eac36561a..b055dc20d3997043bde87735f5b2cdbce301a6f1 100644

--- a/build/android/pylib/local/device/local_device_environment.py

+++ b/build/android/pylib/local/device/local_device_environment.py

@@ -94,7 +94,9 @@ class LocalDeviceEnvironment(environment.Environment):

self._skip_clear_data = args.skip_clear_data

self._target_devices_file = args.target_devices_file

self._tool_name = args.tool

- self._trace_output = args.trace_output

+ self._trace_output = None

+ if hasattr(args, 'trace_output'):

+ self._trace_output = args.trace_output

jbudorick 2017/05/09 19:33:33 nit: 2 space indent

devil_chromium.Initialize(

output_directory=constants.GetOutDirectory(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »