Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2872813002: Add support for creating source ranges (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/utilities/range_factory.dart View 1 chunk +118 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/support/abstract_single_unit.dart View 1 chunk +115 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/utilities/range_factory_test.dart View 1 chunk +108 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-08 21:58:38 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-08 22:00:58 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-09 15:28:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbb37dae8bcad800d204ac0c5a1d266baa324d6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698