Notify paint for each frame

third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintController.h"
 
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/paint/ClipPathDisplayItem.h"
 #include "platform/graphics/paint/ClipPathRecorder.h"
@@ skipping 2038 matching lines @@
              FloatRect(0, 0, 100, 100));
     for (int j = 0; j < 50; ++j)
       GetPaintController().CreateAndAppend<EndClipPathDisplayItem>(client);
     GetPaintController().CommitNewDisplayItems(LayoutSize());
     EXPECT_FALSE(GetPaintController()
                      .GetPaintArtifact()
                      .IsSuitableForGpuRasterization());
   }
 }
 
+TEST_F(PaintControllerTestBase, BeginAndEndFrame) {
+  class FakeFrame {};
+
+  // PaintController should have one null frame in the stack since beginning.
+  FrameFirstPaint result = GetPaintController().EndFrame(nullptr);

[Xianzhu, 2017/05/09 23:13:08]

Add a SetXXXPainted() before this line to ensure it won't crash before the first
BeginFrame().

[Zhen Wang, 2017/05/09 23:26:24]

Done.

+  EXPECT_FALSE(result.first_painted);
+  EXPECT_FALSE(result.text_painted);
+  EXPECT_FALSE(result.image_painted);
+  // Readd the null frame.
+  GetPaintController().BeginFrame(nullptr);
+
+  std::unique_ptr<FakeFrame> frame1(new FakeFrame);
+  GetPaintController().BeginFrame(frame1.get());
+  GetPaintController().SetFirstPainted();
+  GetPaintController().SetTextPainted();
+  GetPaintController().SetImagePainted();
+
+  result = GetPaintController().EndFrame(frame1.get());
+  EXPECT_TRUE(result.first_painted);
+  EXPECT_TRUE(result.text_painted);
+  EXPECT_TRUE(result.image_painted);
+
+  std::unique_ptr<FakeFrame> frame2(new FakeFrame);
+  GetPaintController().BeginFrame(frame2.get());
+  GetPaintController().SetFirstPainted();
+
+  std::unique_ptr<FakeFrame> frame3(new FakeFrame);
+  GetPaintController().BeginFrame(frame3.get());
+  GetPaintController().SetTextPainted();
+  GetPaintController().SetImagePainted();
+
+  result = GetPaintController().EndFrame(frame3.get());
+  EXPECT_FALSE(result.first_painted);
+  EXPECT_TRUE(result.text_painted);
+  EXPECT_TRUE(result.image_painted);
+
+  result = GetPaintController().EndFrame(frame2.get());
+  EXPECT_TRUE(result.first_painted);
+  EXPECT_FALSE(result.text_painted);
+  EXPECT_FALSE(result.image_painted);
+}
+
 // Death tests don't work properly on Android.
 #if defined(GTEST_HAS_DEATH_TEST) && !OS(ANDROID)
 
 class PaintControllerUnderInvalidationTest
     : public PaintControllerTestBase,
       private ScopedPaintUnderInvalidationCheckingForTest {
  public:
   PaintControllerUnderInvalidationTest()
       : PaintControllerTestBase(),
         ScopedPaintUnderInvalidationCheckingForTest(true) {}
@@ skipping 249 matching lines @@
 TEST_F(PaintControllerUnderInvalidationTest, InvalidationInSubsequence) {
   // We allow invalidated display item clients as long as they would produce the
   // same display items. The cases of changed display items are tested by other
   // test cases.
   TestInvalidationInSubsequence();
 }
 
 #endif  // defined(GTEST_HAS_DEATH_TEST) && !OS(ANDROID)
 
 }  // namespace blink