Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/android/vr_shell/ui_scene_manager.cc

Issue 2872773002: VR: Render the current URL and security level on the URL bar. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/ui_scene_manager.cc
diff --git a/chrome/browser/android/vr_shell/ui_scene_manager.cc b/chrome/browser/android/vr_shell/ui_scene_manager.cc
index a02e59c5dfaa05aba6eee10abb744dff0ca0b6a0..cdeb7d88be77d79200165222d21ee741429694b7 100644
--- a/chrome/browser/android/vr_shell/ui_scene_manager.cc
+++ b/chrome/browser/android/vr_shell/ui_scene_manager.cc
@@ -188,6 +188,8 @@ void UiSceneManager::CreateUrlBar() {
element->set_id(AllocateId());
element->set_translation({0, -0.9, -1.8});
element->set_size({0.9, 0, 1});
+ element->SetBackButtonCallback(
+ base::Bind(&UiSceneManager::OnBackButtonClicked, base::Unretained(this)));
url_bar_ = element.get();
browser_ui_elements_.push_back(element.get());
scene_->AddUiElement(std::move(element));
@@ -204,6 +206,7 @@ void UiSceneManager::SetWebVrMode(bool web_vr) {
for (UiElement* element : browser_ui_elements_) {
element->set_visible(!web_vr_mode_);
}
+ url_bar_->SetEnabled(!web_vr);
ConfigureSecurityWarnings();
}
@@ -241,13 +244,19 @@ void UiSceneManager::OnSecurityWarningTimer() {
transient_security_warning_->set_visible(false);
}
+void UiSceneManager::OnBackButtonClicked() {
+ browser_->NavigateBack();
+}
+
void UiSceneManager::SetURL(const GURL& gurl) {
url_bar_->SetURL(gurl);
}
void UiSceneManager::SetFullscreen(bool enabled) {}
-void UiSceneManager::SetSecurityLevel(int level) {}
+void UiSceneManager::SetSecurityLevel(int level) {
+ url_bar_->SetSecurityLevel(level);
+}
void UiSceneManager::SetLoading(bool loading) {}

Powered by Google App Engine
This is Rietveld 408576698