VR: Render the current URL and security level on the URL bar.

chrome/browser/android/vr_shell/vr_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 #include <android/native_window_jni.h>
 
 #include <string>
 #include <utility>
@@ skipping 207 matching lines @@
     return;
 
   // TODO(mthiesse): The page is no longer visible when in menu mode. We
   // should unfocus or otherwise let it know it's hidden.
   if (paused)
     delegate_provider_->device_provider()->Device()->OnBlur();
   else
     delegate_provider_->device_provider()->Device()->OnFocus();
 }
 
+void VrShell::NavigateBack() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  Java_VrShellImpl_navigateBack(env, j_vr_shell_.obj());

[amp, 2017/05/08 21:45:24]

I was going to say we should wire up exiting full screen, but then I remembered
that we don't show the ui in full screen... :)

[tiborg, 2017/05/09 15:00:36]

Also, isn't fullscreen automatically exited when you navigate?

[amp, 2017/05/09 16:38:07]

Yes it should be, although I'm not sure where that is wired up.

The main concern was if we are not doing what the user expected.  If the user
pressed back and expected to get back to the page where they started the full
screen, then navigating to the page previous to that would be bad.  That's why
we had the check in there before, to just exit fullscreen instead of navigating
away.

Since we will no longer have navigation ability in VR fullscreen anymore that
shouldn't be an issue.

+}
+
 void VrShell::OnTriggerEvent(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   gl_thread_->task_runner()->PostTask(
       FROM_HERE,
       base::Bind(&VrShellGl::OnTriggerEvent, gl_thread_->GetVrShellGl()));
 }
 
 void VrShell::OnPause(JNIEnv* env, const JavaParamRef<jobject>& obj) {
   gl_thread_->task_runner()->PostTask(
       FROM_HERE, base::Bind(&VrShellGl::OnPause, gl_thread_->GetVrShellGl()));
 
@@ skipping 169 matching lines @@
                                      height));
   compositor_->SetWindowBounds(gfx::Size(width, height));
 }
 
 // Note that the following code is obsolete and is here as reference for the
 // actions that need to be implemented natively.
 void VrShell::DoUiAction(const UiAction action,
                          const base::DictionaryValue* arguments) {
   // Actions that can be handled natively.
   switch (action) {
-    case HISTORY_BACK:
-      if (web_contents_ && web_contents_->IsFullscreen()) {
-        web_contents_->ExitFullscreen(false);
-        return;
-      }
-      // Otherwise handle in java.
-      break;
     case EXIT_PRESENT:
       delegate_provider_->ExitWebVRPresent();
       return;
     default:
       break;
   }
   // Actions that are handled in java.
   JNIEnv* env = base::android::AttachCurrentThread();
   switch (action) {
     case SHOW_TAB: {
       int id;
       CHECK(arguments->GetInteger("id", &id));
       Java_VrShellImpl_showTab(env, j_vr_shell_.obj(), id);
       return;
     }
     case OPEN_NEW_TAB: {
       bool incognito;
       CHECK(arguments->GetBoolean("incognito", &incognito));
       Java_VrShellImpl_openNewTab(env, j_vr_shell_.obj(), incognito);
       return;
     }
-    case HISTORY_BACK:
-      Java_VrShellImpl_navigateBack(env, j_vr_shell_.obj());
-      break;
     case HISTORY_FORWARD:
       Java_VrShellImpl_navigateForward(env, j_vr_shell_.obj());
       break;
     case RELOAD:
       Java_VrShellImpl_reload(env, j_vr_shell_.obj());
       break;
     default:
       NOTREACHED();
   }
 }
@@ skipping 92 matching lines @@
            jlong gvr_api,
            jboolean reprojected_rendering) {
   return reinterpret_cast<intptr_t>(new VrShell(
       env, obj, reinterpret_cast<ui::WindowAndroid*>(window_android),
       for_web_vr, in_cct,
       VrShellDelegate::GetNativeVrShellDelegate(env, delegate),
       reinterpret_cast<gvr_context*>(gvr_api), reprojected_rendering));
 }
 
 }  // namespace vr_shell