Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: third_party/WebKit/Source/modules/imagecapture/ImageCapture.h

Issue 2872713002: Revert of Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
diff --git a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
index 31f1d79a2cf537065002e87222dbeee703538b5e..e1138bdc8fd23a87af15ed6df899d70999938b93 100644
--- a/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
+++ b/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
@@ -56,12 +56,9 @@
ScriptPromise getPhotoCapabilities(ScriptState*);
- ScriptPromise setOptions(ScriptState*,
- const PhotoSettings&,
- bool trigger_take_photo = false);
+ ScriptPromise setOptions(ScriptState*, const PhotoSettings&);
ScriptPromise takePhoto(ScriptState*);
- ScriptPromise takePhoto(ScriptState*, const PhotoSettings&);
ScriptPromise grabFrame(ScriptState*);
@@ -80,15 +77,14 @@
private:
ImageCapture(ExecutionContext*, MediaStreamTrack*);
- void OnMojoPhotoCapabilities(ScriptPromiseResolver*,
- bool trigger_take_photo,
- media::mojom::blink::PhotoCapabilitiesPtr);
- void OnMojoSetOptions(ScriptPromiseResolver*,
- bool trigger_take_photo,
- bool result);
- void OnMojoTakePhoto(ScriptPromiseResolver*, media::mojom::blink::BlobPtr);
+ void OnPhotoCapabilities(ScriptPromiseResolver*,
+ media::mojom::blink::PhotoCapabilitiesPtr);
+ void OnSetOptions(ScriptPromiseResolver*, bool);
+ void OnTakePhoto(ScriptPromiseResolver*, media::mojom::blink::BlobPtr);
+ void OnCapabilitiesUpdate(media::mojom::blink::PhotoCapabilitiesPtr);
- void UpdateMediaTrackCapabilities(media::mojom::blink::PhotoCapabilitiesPtr);
+ void OnCapabilitiesUpdateInternal(
+ const media::mojom::blink::PhotoCapabilities&);
void OnServiceConnectionError();
Member<MediaStreamTrack> stream_track_;

Powered by Google App Engine
This is Rietveld 408576698