Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: components/metrics/single_sample_metrics_factory_impl_unittest.cc

Issue 2872623003: Disable flaky SingleSampleMetricsFactoryImplTest.MultithreadedMetrics test (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/single_sample_metrics_factory_impl_unittest.cc
diff --git a/components/metrics/single_sample_metrics_factory_impl_unittest.cc b/components/metrics/single_sample_metrics_factory_impl_unittest.cc
index 0ef75be789851849150efcea49c5b78823994600..d87d3fd1ee6442b6253eab0544a517b567f57102 100644
--- a/components/metrics/single_sample_metrics_factory_impl_unittest.cc
+++ b/components/metrics/single_sample_metrics_factory_impl_unittest.cc
@@ -131,7 +131,13 @@ TEST_F(SingleSampleMetricsFactoryImplTest, DefaultSingleSampleMetricWithValue) {
base::HistogramBase::kUmaTargetedHistogramFlag));
}
-TEST_F(SingleSampleMetricsFactoryImplTest, MultithreadedMetrics) {
+// Flaky on Android N5X builders. https://crbug.com/719497
+#if defined(OS_ANDROID)
+#define MAYBE_MultithreadedMetrics DISABLED_MultithreadedMetrics
+#else
+#define MAYBE_MultithreadedMetrics MultithreadedMetrics
+#endif
+TEST_F(SingleSampleMetricsFactoryImplTest, MAYBE_MultithreadedMetrics) {
base::HistogramTester tester;
std::unique_ptr<base::SingleSampleMetric> metric =
factory_->CreateCustomCountsMetric(kMetricName, kMin, kMax, kBucketCount);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698