[Web Payments] Add "pencil" edit button to lists.

chrome/browser/ui/views/payments/profile_list_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/profile_list_view_controller.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
 #include "chrome/browser/ui/views/payments/payment_request_row_view.h"
@@ skipping 22 matching lines @@
 constexpr int kFirstTagValue = static_cast<int>(
     payments::PaymentRequestCommonTags::PAYMENT_REQUEST_COMMON_TAG_MAX);
 
 enum class PaymentMethodViewControllerTags : int {
   // The tag for the button that triggers the "add address" flow. Starts at
   // |kFirstTagValue| not to conflict with tags common to all views.
   ADD_SHIPPING_ADDRESS_BUTTON = kFirstTagValue,
   ADD_CONTACT_BUTTON,
 };
 
 class ProfileItem : public PaymentRequestItemList::Item {

[Evan Stade, 2017/05/12 18:48:07]

while I'm poking around (and this doesn't have to be addressed right now)...

It looks like this class is just a thunk that passes through almost all
overrides of PaymentRequestItemList::Item methods to
ShippingProfileViewController. It seems like what you want is
PaymentRequestItemList::Item to define a delegate interface that
ShippingProfileViewController implements, rather than having this subclass that
redirects the calls.

[anthonyvd, 2017/05/12 20:16:48]

Ack.

  public:
   // Constructs an object owned by |parent_list|, representing one element in
   // the list. |spec| and |state| are the PaymentRequestSpec/State objects that
   // are represented by the current instance of the dialog. |parent_view| points
   // to the controller which owns |parent_list|. |profile| is the
   // AutofillProfile that this specific list item represents. It's a cached
   // profile owned by |state|.
   ProfileItem(autofill::AutofillProfile* profile,
               PaymentRequestSpec* spec,
               PaymentRequestState* state,
               PaymentRequestItemList* parent_list,
               ProfileListViewController* parent_view,
               PaymentRequestDialogView* dialog,
               bool selected)
       : payments::PaymentRequestItemList::Item(spec,
                                                state,
                                                parent_list,
-                                               selected),
+                                               selected,
+                                               /*show_edit_button=*/true),
         parent_view_(parent_view),
         profile_(profile),
         dialog_(dialog) {}
   ~ProfileItem() override {}
 
  private:
   // payments::PaymentRequestItemList::Item:
   std::unique_ptr<views::View> CreateContentView() override {
     DCHECK(profile_);
 
@@ skipping 15 matching lines @@
     // PerformSelectionFallback() is called.
     return IsEnabled() && parent_view_->IsValidProfile(*profile_);
   }
 
   void PerformSelectionFallback() override {
     // If enabled, the editor is opened to complete the invalid profile.
     if (IsEnabled())
       parent_view_->ShowEditor(profile_);
   }
 
+  void EditButtonPressed() override { parent_view_->ShowEditor(profile_); }
+
   ProfileListViewController* parent_view_;

[Evan Stade, 2017/05/12 18:48:07]

nit: confusing that the controller is named parent_view_

[anthonyvd, 2017/05/12 20:16:48]

Done.

   autofill::AutofillProfile* profile_;
   PaymentRequestDialogView* dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileItem);
 };
 
 // The ProfileListViewController subtype for the Shipping address list
 // screen of the Payment Request flow.
 class ShippingProfileViewController : public ProfileListViewController {
  public:
@@ skipping 266 matching lines @@
 
 void ProfileListViewController::ButtonPressed(views::Button* sender,
                                               const ui::Event& event) {
   if (sender->tag() == GetSecondaryButtonTag())
     ShowEditor(nullptr);
   else
     PaymentRequestSheetController::ButtonPressed(sender, event);
 }
 
 }  // namespace payments