[Web Payments] Add "pencil" edit button to lists.

chrome/browser/ui/views/payments/payment_request_item_list.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_
 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "ui/views/controls/button/button.h"
 
 namespace views {
+class ImageButton;
 class ImageView;
 class View;
 }
 
 namespace payments {
 
 class PaymentRequestSpec;
 class PaymentRequestState;
 
 // A control representing a list of selectable items in the PaymentRequest
 // dialog. These lists enforce that only one of their elements be selectable at
 // a time and that "incomplete" items (for example, a credit card with no known
 // expiration date) behave differently when selected. Most of the time, this
 // behavior is to show an editor screen.
 class PaymentRequestItemList {
  public:
   // Represents an item in the item list.
   class Item : public views::ButtonListener {
    public:
     // Creates an item that will be owned by |list| with the initial state set
     // to |selected|.
     Item(PaymentRequestSpec* spec,
          PaymentRequestState* state,
          PaymentRequestItemList* list,
-         bool selected);
+         bool selected,
+         bool show_edit_button);
     ~Item() override;
 
     // Gets the view associated with this item. It's owned by this object so
     // that it can listen to any changes to the underlying model and update the
     // view.
     views::View* GetItemView();
 
     bool selected() const { return selected_; }
     // Changes the selected state of this item to |selected|.
     // SelectedStateChanged is called if |notify| is true.
@@ skipping 32 matching lines @@
 
     // Returns whether this item is complete/valid and can be selected by the
     // user. If this returns false when the user attempts to select this item,
     // PerformSelectionFallback will be called instead.
     virtual bool CanBeSelected() = 0;
 
     // Performs the action that replaces selection when CanBeSelected returns
     // false. This will usually be to display an editor.
     virtual void PerformSelectionFallback() = 0;
 
+    // Called when the edit button is pressed. Subclasses should open the editor
+    // appropriate for the item they represent.
+    virtual void EditButtonPressed() = 0;
+
    private:
     // Creates and returns the view associated with this list item.
     std::unique_ptr<views::View> CreateItemView();
 
     // views::ButtonListener:
     void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
     std::unique_ptr<views::View> item_view_;
     PaymentRequestSpec* spec_;
     PaymentRequestState* state_;
     PaymentRequestItemList* list_;
     std::unique_ptr<views::ImageView> checkmark_;
+    std::unique_ptr<views::ImageButton> edit_button_;

[sky, 2017/05/12 01:28:48]

I think a better approach here is to not have the member at all. Instead use a
tag or id on the button to identify in the listener.

     bool selected_;
+    bool show_edit_button_;
 
     DISALLOW_COPY_AND_ASSIGN(Item);
   };
 
   PaymentRequestItemList();
   virtual ~PaymentRequestItemList();
 
   // Adds an item to this list. |item->list()| should return this object.
   void AddItem(std::unique_ptr<Item> item);
 
@@ skipping 13 matching lines @@
 
   std::vector<std::unique_ptr<Item>> items_;
   Item* selected_item_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestItemList);
 };
 
 }  // namespace payments
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_ITEM_LIST_H_