Issue 2872603002: Revert "Warn when adding something to a closed sink and improve documentation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2872603002: Revert "Warn when adding something to a closed sink and improve documentation." (Closed)

Created:
3 years, 7 months ago by floitsch

Modified:
3 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Warn when adding something to a closed sink and improve documentation." This reverts commit c0090fa01fe59b7982891b8c4e34ed4cabd2296f. Committed: https://github.com/dart-lang/sdk/commit/a4eb8b8fe36f2a8de24a265b63de164719d66517

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -118 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	3 chunks	+11 lines, -27 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1 chunk	+1 line, -30 lines	0 comments	Download
M	sdk/lib/async/stream_transformers.dart	View	3 chunks	+4 lines, -27 lines	0 comments	Download
M	sdk/lib/core/sink.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/io_sink.dart	View	2 chunks	+3 lines, -23 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (2 generated)

floitsch

3 years, 7 months ago (2017-05-08 13:18:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4eb8b8fe36f2a8de24a265b63de164719d66517 (presubmit successful).