Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: components/suggestions/suggestions_service_impl_unittest.cc

Issue 2872573002: Use |min| param to query a variable number of suggestions (Closed)
Patch Set: Rebase (blackboxing unittest) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/suggestions/suggestions_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions/suggestions_service_impl_unittest.cc
diff --git a/components/suggestions/suggestions_service_impl_unittest.cc b/components/suggestions/suggestions_service_impl_unittest.cc
index c12f4b5eac0ffdbecdc638904990e4e400c0a80d..8e0954ed604d43369c2717c18c7c907f5512f0fa 100644
--- a/components/suggestions/suggestions_service_impl_unittest.cc
+++ b/components/suggestions/suggestions_service_impl_unittest.cc
@@ -14,17 +14,20 @@
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/test/mock_callback.h"
+#include "base/test/scoped_feature_list.h"
#include "components/signin/core/browser/account_tracker_service.h"
#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
#include "components/signin/core/browser/fake_signin_manager.h"
#include "components/signin/core/browser/test_signin_client.h"
#include "components/suggestions/blacklist_store.h"
+#include "components/suggestions/features.h"
#include "components/suggestions/image_manager.h"
#include "components/suggestions/proto/suggestions.pb.h"
#include "components/suggestions/suggestions_store.h"
#include "components/sync/driver/fake_sync_service.h"
#include "components/sync/driver/sync_service.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
+#include "net/base/url_util.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_status_code.h"
#include "net/url_request/test_url_fetcher_factory.h"
@@ -322,6 +325,29 @@ TEST_F(SuggestionsServiceTest, DoesNotFetchOnStartup) {
EXPECT_FALSE(suggestions_service()->has_pending_request_for_testing());
}
+TEST_F(SuggestionsServiceTest, BuildUrlWithDefaultMinZeroParamForFewFeature) {
+ base::test::ScopedFeatureList scoped_feature_list;
+ scoped_feature_list.InitAndEnableFeature(kUseSuggestionsEvenIfFewFeature);
+
+ EXPECT_CALL(*thumbnail_manager(), Initialize(_));
+ EXPECT_CALL(*blacklist_store(), FilterSuggestions(_));
+ EXPECT_CALL(*blacklist_store(), GetTimeUntilReadyForUpload(_))
+ .WillOnce(Return(false));
+
+ // Send the request. The data should be returned to the callback.
+ suggestions_service()->FetchSuggestionsData();
+
+ // Wait for the eventual network request.
+ base::RunLoop().RunUntilIdle();
+ ASSERT_TRUE(GetCurrentlyQueriedUrl().is_valid());
+ EXPECT_EQ(GetCurrentlyQueriedUrl().path(), kSuggestionsUrlPath);
+ std::string min_suggestions;
+ EXPECT_TRUE(net::GetValueForKeyInQuery(GetCurrentlyQueriedUrl(), "min",
+ &min_suggestions));
+ EXPECT_EQ(min_suggestions, "0");
+ RespondToFetchWithProfile(CreateSuggestionsProfile());
+}
+
TEST_F(SuggestionsServiceTest, FetchSuggestionsDataSyncNotInitializedEnabled) {
EXPECT_CALL(*sync_service(), IsSyncActive()).WillRepeatedly(Return(false));
static_cast<SyncServiceObserver*>(suggestions_service())
« no previous file with comments | « components/suggestions/suggestions_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698