Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: components/suggestions/suggestions_service_impl.h

Issue 2872573002: Use |min| param to query a variable number of suggestions (Closed)
Patch Set: Use format strings to concat parameters Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_ 5 #ifndef COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_
6 #define COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_ 6 #define COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 private: 87 private:
88 friend class SuggestionsServiceTest; 88 friend class SuggestionsServiceTest;
89 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData); 89 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, FetchSuggestionsData);
90 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, IgnoresNoopSyncChange); 90 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, IgnoresNoopSyncChange);
91 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 91 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
92 IgnoresUninterestingSyncChange); 92 IgnoresUninterestingSyncChange);
93 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 93 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
94 FetchSuggestionsDataSyncNotInitializedEnabled); 94 FetchSuggestionsDataSyncNotInitializedEnabled);
95 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 95 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
96 BuildUrlWithMinEqualsZeroParamForFewFeature);
97 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
96 FetchSuggestionsDataSyncDisabled); 98 FetchSuggestionsDataSyncDisabled);
97 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 99 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
98 FetchSuggestionsDataNoAccessToken); 100 FetchSuggestionsDataNoAccessToken);
99 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 101 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
100 IssueRequestIfNoneOngoingError); 102 IssueRequestIfNoneOngoingError);
101 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, 103 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest,
102 IssueRequestIfNoneOngoingResponseNotOK); 104 IssueRequestIfNoneOngoingResponseNotOK);
103 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURL); 105 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURL);
104 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURLRequestFails); 106 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, BlacklistURLRequestFails);
105 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, ClearBlacklist); 107 FRIEND_TEST_ALL_PREFIXES(SuggestionsServiceTest, ClearBlacklist);
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 243
242 // For callbacks may be run after destruction. 244 // For callbacks may be run after destruction.
243 base::WeakPtrFactory<SuggestionsServiceImpl> weak_ptr_factory_; 245 base::WeakPtrFactory<SuggestionsServiceImpl> weak_ptr_factory_;
244 246
245 DISALLOW_COPY_AND_ASSIGN(SuggestionsServiceImpl); 247 DISALLOW_COPY_AND_ASSIGN(SuggestionsServiceImpl);
246 }; 248 };
247 249
248 } // namespace suggestions 250 } // namespace suggestions
249 251
250 #endif // COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_ 252 #endif // COMPONENTS_SUGGESTIONS_SUGGESTIONS_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | components/suggestions/suggestions_service_impl.cc » ('j') | components/suggestions/suggestions_service_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698