Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 2872503004: vm-service: Add optional 'scope' parameter to 'evaluate' and 'evaluateInFrame'. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl.cc
diff --git a/runtime/vm/debugger_api_impl.cc b/runtime/vm/debugger_api_impl.cc
index a49cc93c2b69fa2d397663a5284ca9e0d841550e..c95094df8ac3a754e3c3e4ea911ecb516e7510d0 100644
--- a/runtime/vm/debugger_api_impl.cc
+++ b/runtime/vm/debugger_api_impl.cc
@@ -565,7 +565,11 @@ Dart_ActivationFrameEvaluate(Dart_ActivationFrame activation_frame,
CHECK_DEBUGGER(T->isolate());
CHECK_AND_CAST(ActivationFrame, frame, activation_frame);
UNWRAP_AND_CHECK_PARAM(String, expr, expr_in);
- return Api::NewHandle(T, frame->Evaluate(expr));
+ const GrowableObjectArray& names =
+ GrowableObjectArray::Handle(GrowableObjectArray::New());
+ const GrowableObjectArray& values =
+ GrowableObjectArray::Handle(GrowableObjectArray::New());
+ return Api::NewHandle(T, frame->Evaluate(expr, names, values));
}
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698