Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 2872503003: Add crash keys about field trial shared memory errors. (Closed)
Patch Set: Add TODOs about cleaning up the code. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 // Temporary for https://crbug.com/668633. 236 // Temporary for https://crbug.com/668633.
237 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize}, 237 {"swdh_set_hosted_version_worker_pid", crash_keys::kSmallSize},
238 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize}, 238 {"swdh_set_hosted_version_host_pid", crash_keys::kSmallSize},
239 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize}, 239 {"swdh_set_hosted_version_is_new_process", crash_keys::kSmallSize},
240 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize}, 240 {"swdh_set_hosted_version_restart_count", crash_keys::kSmallSize},
241 241
242 // Temporary for https://crbug.com/697745. 242 // Temporary for https://crbug.com/697745.
243 {"engine_params", crash_keys::kMediumSize}, 243 {"engine_params", crash_keys::kMediumSize},
244 {"engine1_params", crash_keys::kMediumSize}, 244 {"engine1_params", crash_keys::kMediumSize},
245 {"engine2_params", crash_keys::kMediumSize}, 245 {"engine2_params", crash_keys::kMediumSize},
246
247 // Temporary for http://crbug.com/703649.
248 {"field_trial_shmem_create_error", crash_keys::kSmallSize},
249 {"field_trial_shmem_map_error", crash_keys::kSmallSize},
246 }; 250 };
247 251
248 // This dynamic set of keys is used for sets of key value pairs when gathering 252 // This dynamic set of keys is used for sets of key value pairs when gathering
249 // a collection of data, like command line switches or extension IDs. 253 // a collection of data, like command line switches or extension IDs.
250 std::vector<base::debug::CrashKey> keys( 254 std::vector<base::debug::CrashKey> keys(
251 fixed_keys, fixed_keys + arraysize(fixed_keys)); 255 fixed_keys, fixed_keys + arraysize(fixed_keys));
252 256
253 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 257 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
254 258
255 // Register the extension IDs. 259 // Register the extension IDs.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 } 376 }
373 377
374 ScopedPrinterInfo::~ScopedPrinterInfo() { 378 ScopedPrinterInfo::~ScopedPrinterInfo() {
375 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 379 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
376 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 380 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
377 base::debug::ClearCrashKey(key); 381 base::debug::ClearCrashKey(key);
378 } 382 }
379 } 383 }
380 384
381 } // namespace crash_keys 385 } // namespace crash_keys
OLDNEW
« base/memory/shared_memory_posix.cc ('K') | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698